Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add "Ignore tablespace" to Schema Diff #6004

Closed
jflambert opened this issue Mar 23, 2023 · 2 comments
Closed

Add "Ignore tablespace" to Schema Diff #6004

jflambert opened this issue Mar 23, 2023 · 2 comments
Assignees
@yogeshmahajan-1903
Labels
EDB Sprint 149 Feature
Milestone
7.6

Comments

@jflambert
Copy link

Describe the solution you'd like

In the "Compare" button dropdown (which has Ignore owner/whitespace) I would like to have a new "Ignore tablespace" option.

Some of my database tables have an explicit TABLESPACE pg_default; setting and some others don't have it declared at all. I'm not sure why. Of course, not declaring tablespace is equivalent to using pg_default. I'm using various docker flavours, some from timescaledb, some from debian, some on alpine. That must be why.

Describe alternatives you've considered

I'm not even sure I can redeclare tablespace post initdb. For now I just ignore these diffs, but I get a lot of false flags.

Additional context

Worth mentioning that even though there is a difference, the Difference panel doesn't show an instruction.

image
@stanhu
Copy link

stanhu commented Jul 20, 2023

I would like this too! I have over 5000 lines in a diff with ALTER X SET TABLESPACE pg_default;.

@akshay-joshi akshay-joshi self-assigned this Aug 2, 2023
@akshay-joshi akshay-joshi added this to the 7.6 milestone Aug 9, 2023
akshay-joshi added a commit to akshay-joshi/pgadmin4 that referenced this issue Aug 11, 2023
@akshay-joshi
1) Added 'Ignore Grants' option in the schema diff tool. pgadmin-org#…
05dc3f8 
…5759

2) Added 'Ignore Tablespace' option in the schema diff tool. pgadmin-org#6004
3) Ensure that Schema Diff comparison results should be displayed in the sorted order. pgadmin-org#6595
4) Fixed an issue where the SET directive is excluded from the function header in the schema diff tool. pgadmin-org#6651
akshay-joshi added a commit to akshay-joshi/pgadmin4 that referenced this issue Aug 11, 2023
@akshay-joshi
1) Added 'Ignore Grants' option in the schema diff tool. pgadmin-org#…
9145db8 
…5759

2) Added 'Ignore Tablespace' option in the schema diff tool. pgadmin-org#6004
3) Ensure that Schema Diff comparison results should be displayed in the sorted order. pgadmin-org#6595
4) Fixed an issue where the SET directive is excluded from the function header in the schema diff tool. pgadmin-org#6651
akshay-joshi added a commit to akshay-joshi/pgadmin4 that referenced this issue Aug 11, 2023
@akshay-joshi
1) Added 'Ignore Grants' option in the schema diff tool. pgadmin-org#…
278e698 
…5759

2) Added 'Ignore Tablespace' option in the schema diff tool. pgadmin-org#6004
3) Ensure that Schema Diff comparison results should be displayed in the sorted order. pgadmin-org#6595
4) Fixed an issue where the SET directive is excluded from the function header in the schema diff tool. pgadmin-org#6651

Update preferneces documentation and screenshot
@akshay-joshi akshay-joshi mentioned this issue Aug 11, 2023
Merged
akshay-joshi added a commit to akshay-joshi/pgadmin4 that referenced this issue Aug 11, 2023
@akshay-joshi
1) Added 'Ignore Grants' option in the schema diff tool. pgadmin-org#…
be89a71 
…5759

2) Added 'Ignore Tablespace' option in the schema diff tool. pgadmin-org#6004
3) Ensure that Schema Diff comparison results should be displayed in the sorted order. pgadmin-org#6595
4) Fixed an issue where the SET directive is excluded from the function header in the schema diff tool. pgadmin-org#6651

Update preferneces documentation and screenshot

Fixed review comments.
akshay-joshi added a commit that referenced this issue Aug 11, 2023
@akshay-joshi
1) Added 'Ignore Grants' option in the schema diff tool. #5759
3c43aa1 
2) Added 'Ignore Tablespace' option in the schema diff tool. #6004
3) Ensure that Schema Diff comparison results should be displayed in the sorted order. #6595
4) Fixed an issue where the SET directive is excluded from the function header in the schema diff tool. #6651
@yogeshmahajan-1903
Copy link
Contributor

Working fine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yogeshmahajan-1903 yogeshmahajan-1903

Labels
EDB Sprint 149 Feature
Projects
None yet
Milestone
7.6
Development

No branches or pull requests
4 participants
@stanhu @akshay-joshi @jflambert @yogeshmahajan-1903