Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SchemaDiffTool: utilities exclude the SET directive from the function header in compare mode. #6651

Closed
firstDismay opened this issue Aug 3, 2023 · 1 comment
Closed

SchemaDiffTool: utilities exclude the SET directive from the function header in compare mode. #6651

firstDismay opened this issue Aug 3, 2023 · 1 comment
Assignees
@yogeshmahajan-1903
Labels
Bug EDB Sprint 149
Milestone
7.6

Comments

@firstDismay
Copy link

firstDismay commented Aug 3, 2023 •
edited

Hi
Schema diff utilities exclude the SET directive from the function header in compare mode.
Reproducing the problem:

  1. Create a copy of the database that has a function containing the SET directive
  2. Modify the function and perform the comparison.
    The resulting script lacks the SET directive in the function:
CREATE OR REPLACE FUNCTION bpd.class_del(
iid bigint)
    RETURNS void
    LANGUAGE 'plpgsql'
    COST 100
    VOLATILE SECURITY DEFINER PARALLEL UNSAFE
    <--SET search_path=bpd, err-->
AS $BODY$
@akshay-joshi akshay-joshi self-assigned this Aug 4, 2023
@akshay-joshi akshay-joshi added this to the 7.6 milestone Aug 10, 2023
akshay-joshi added a commit to akshay-joshi/pgadmin4 that referenced this issue Aug 11, 2023
@akshay-joshi
1) Added 'Ignore Grants' option in the schema diff tool. pgadmin-org#…
05dc3f8 
…5759

2) Added 'Ignore Tablespace' option in the schema diff tool. pgadmin-org#6004
3) Ensure that Schema Diff comparison results should be displayed in the sorted order. pgadmin-org#6595
4) Fixed an issue where the SET directive is excluded from the function header in the schema diff tool. pgadmin-org#6651
akshay-joshi added a commit to akshay-joshi/pgadmin4 that referenced this issue Aug 11, 2023
@akshay-joshi
1) Added 'Ignore Grants' option in the schema diff tool. pgadmin-org#…
9145db8 
…5759

2) Added 'Ignore Tablespace' option in the schema diff tool. pgadmin-org#6004
3) Ensure that Schema Diff comparison results should be displayed in the sorted order. pgadmin-org#6595
4) Fixed an issue where the SET directive is excluded from the function header in the schema diff tool. pgadmin-org#6651
akshay-joshi added a commit to akshay-joshi/pgadmin4 that referenced this issue Aug 11, 2023
@akshay-joshi
1) Added 'Ignore Grants' option in the schema diff tool. pgadmin-org#…
278e698 
…5759

2) Added 'Ignore Tablespace' option in the schema diff tool. pgadmin-org#6004
3) Ensure that Schema Diff comparison results should be displayed in the sorted order. pgadmin-org#6595
4) Fixed an issue where the SET directive is excluded from the function header in the schema diff tool. pgadmin-org#6651

Update preferneces documentation and screenshot
@akshay-joshi akshay-joshi mentioned this issue Aug 11, 2023
Merged
akshay-joshi added a commit to akshay-joshi/pgadmin4 that referenced this issue Aug 11, 2023
@akshay-joshi
1) Added 'Ignore Grants' option in the schema diff tool. pgadmin-org#…
be89a71 
…5759

2) Added 'Ignore Tablespace' option in the schema diff tool. pgadmin-org#6004
3) Ensure that Schema Diff comparison results should be displayed in the sorted order. pgadmin-org#6595
4) Fixed an issue where the SET directive is excluded from the function header in the schema diff tool. pgadmin-org#6651

Update preferneces documentation and screenshot

Fixed review comments.
akshay-joshi added a commit that referenced this issue Aug 11, 2023
@akshay-joshi
1) Added 'Ignore Grants' option in the schema diff tool. #5759
3c43aa1 
2) Added 'Ignore Tablespace' option in the schema diff tool. #6004
3) Ensure that Schema Diff comparison results should be displayed in the sorted order. #6595
4) Fixed an issue where the SET directive is excluded from the function header in the schema diff tool. #6651
@yogeshmahajan-1903
Copy link
Contributor

Working fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yogeshmahajan-1903 yogeshmahajan-1903

Labels
Bug EDB Sprint 149
Projects
None yet
Milestone
7.6
Development

No branches or pull requests
3 participants
@akshay-joshi @yogeshmahajan-1903 @firstDismay