-
Notifications
You must be signed in to change notification settings - Fork 845
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
isValid() timeout should not be blocked #1943
Conversation
how does this work ? Why does setting the time out there block the other one ? |
Hey @davecramer. Ultimately the synchronized block doesn't allow the |
got it, thx |
I am wondering if we can create a test for this ? |
Sure we can. Let me get a bit more context on the tests on the repo and soon I'll send a new one! |
Awesome, thanks! |
Codecov Report
@@ Coverage Diff @@
## master #1943 +/- ##
============================================
+ Coverage 65.35% 69.39% +4.03%
- Complexity 3955 4228 +273
============================================
Files 197 197
Lines 18006 18004 -2
Branches 2919 2919
============================================
+ Hits 11768 12494 +726
+ Misses 4878 4158 -720
+ Partials 1360 1352 -8 |
I've coded a regression test to make sure that |
The usage of `setQueryTimeout();` with the same value as the `setNetworkTimeout();` is blocking the current transaction timeout. The timeouts are blocking each other with this approach.
@hugomiguelabreu , do you think #898 / https://github.com/NetCrusherOrg/netcrusher-java / https://github.com/trekawek/toxiproxy-java would be helpful here? |
It can be helpful for this specific test, nevertheless it's for this specific case, a more overview of the project tests should be analyzed. |
@vlsi we should probably backpatch this. |
The usage of `setQueryTimeout();` with the same value as the `setNetworkTimeout();` is blocking the current transaction timeout. The timeouts are blocking each other with this approach.
The usage of
setQueryTimeout();
with the same value as thesetNetworkTimeout();
is blocking the current transaction timeout.The timeouts are blocking each other with this approach.
All Submissions:
New Feature Submissions:
./gradlew autostyleCheck checkstyleAll
pass ?Changes to Existing Features: