marking most functions as PARALLEL SAFE #218
Conversation
|
Aggregates could probably be marked PARALLEL SAFE as well. One issue is that, in their current forms, the changes break the compatibility with PostgreSQL < 9.6. PostGIS pre-processes the postgis.sql.in files to address that problem. |
|
@elemoine : Is compatibility with PostgreSQL < 9.6 a requirement for pointcloud? |
I think it would be a shame if we did not support PostgreSQL < 9.5 just because of |
tsl-karlp
force-pushed
the
feature/parallelization
branch
from
b172264
to
72360aa
Compare
|
FWIW PostGIS uses the cpp preprocessor for that. See https://github.com/postgis/postgis/blob/68fc1fec36dc48ac507dc4c8ee3e3f102a68243a/postgis/Makefile.in#L208-L210. |
|
Unfortunately, this was the smallest lift for us, given our time. Feel free to take over. :) |
tsl-karlp
force-pushed
the
feature/parallelization
branch
2 times, most recently
from
5ec05a7
to
0c8f511
Compare
|
@elemoine : I brought over some code from postgis, which detects PG versions at the Is there something missing from this PR? |
NOTE: had to convert CREATE AGGREGATE functions to new-style because of http://www.postgresql-archive.org/reate-parallel-aggregate-td5923553.html
tsl-karlp
force-pushed
the
feature/parallelization
branch
from
0c8f511
to
74bbbe0
Compare
|
Thanks for the work on this @tsl-karlp. This is great. I'll have a look at your patch next week. |
| @@ -44,7 +44,7 @@ if test "x${GITCMD}" = "xyes" -a "x${DOTGITDIR}" = "xyes"; then | |||
| else | |||
| GIT_COMMIT_HASH= | |||
| fi | |||
| POINTCLOUD_VERSION="$(cat Version.config)$GIT_COMMIT_HASH" | |||
| POINTCLOUD_VERSION="$(cat Version.config)" | |||
There was a problem hiding this comment.
Any reason for changing this line?
| PGSQL_MINOR_VERSION=`$PG_CONFIG --version | sed 's/[[A-Za-z ]]*//' | cut -d. -f2 | sed 's/[[^0-9]]//g'` | ||
| dnl the final version. This is to guard against user error... | ||
| PGSQL_MAJOR_VERSION=`$PG_CONFIG --version | sed 's/[[A-Za-z ]]*//' | cut -d. -f1 | sed 's/[[^0-9]]//g'` | ||
| PGSQL_MINOR_VERSION=`$PG_CONFIG --version | sed 's/[[A-Za-z ]]*//' | cut -d. -f2 | sed 's/[[^0-9]]//g'` |
There was a problem hiding this comment.
Trailing white spaces have been added here. They are to be removed again.
|
|
||
| AC_MSG_RESULT([checking PostgreSQL version... $PGSQL_FULL_VERSION]) | ||
|
|
||
| POSTGIS_PGSQL_VERSION="$PGSQL_MAJOR_VERSION$PGSQL_MINOR_VERSION" |
There was a problem hiding this comment.
PostGIS uses the POSTGIS_ prefix because it's PostGIS :) Let's not use the POSTGIS_ prefix in the Pointcloud extension.
|
Superseded by #227 . |
Feedback appreciated. :) . I didn't mark the
upgradefunction as PARALLEL SAFE.Not sure if I got the tests correct, too.