Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Obtain specification field data information from JSON schema #71

Open
cimendes opened this issue Jan 4, 2022 · 1 comment
Open

Obtain specification field data information from JSON schema #71

cimendes opened this issue Jan 4, 2022 · 1 comment
Assignees
Labels

Comments

@cimendes
Copy link
Member

cimendes commented Jan 4, 2022

In the hAMRonizedResult class definition, the field terms for the parsers, and their value types, should be obtained from the schema JSON file and not be hardcoded into the tool. The necessary file is already provided in the schema/ directory. A parser should be included to retrieve this information directly from the file, facilitating the update of the field terms when necessary.

⬇️
https://github.com/pha4ge/hAMRonization/blob/master/hAMRonization/hAMRonizedResult.py#L13-L52

@cimendes cimendes added enhancement New feature or request p1 labels Jan 4, 2022
@cimendes cimendes self-assigned this Jan 4, 2022
@cimendes cimendes added nice to have and removed p1 labels Jan 19, 2022
@cimendes
Copy link
Member Author

My dream lives on... in the lowest priority setting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant