Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix validation regression #22

Closed
bede opened this issue Jun 7, 2024 · 2 comments
Closed

Fix validation regression #22

bede opened this issue Jun 7, 2024 · 2 comments
Milestone
CI done

Comments

@bede
Copy link
Collaborator

bede commented Jun 7, 2024 •
edited
Loading

Faster validation introduced in 90b0017 is not rigorous

Write pytest.raises for these
@bede bede changed the title Fix validation regression in 90b0017da588ac9410388ed2c354bf3dc0c1c3ad Fix validation regression Jun 7, 2024
@bede
Copy link
Collaborator Author

bede commented Jul 23, 2024

Fixed regression, but leaving open until faster validation is reimplemented

@bede bede added this to the v1 milestone Aug 1, 2024
@bede
Copy link
Collaborator Author

bede commented Aug 1, 2024

Fixed, but not performantly

@bede bede closed this as completed Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
CI done
Development

No branches or pull requests
1 participant
@bede