Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix delete project #1348

Merged
merged 5 commits into from Aug 5, 2022
Merged

Fix delete project #1348

merged 5 commits into from Aug 5, 2022

Conversation

ksierks
Copy link
Contributor

@ksierks ksierks commented Aug 5, 2022

Description of changes

A notification with "Internal Error" pops up when a user tries to delete a project with project subscriptions.

This is due to the following:

Caused by: java.sql.SQLIntegrityConstraintViolationException: Cannot delete or update a parent row: a foreign key constraint fails (irida_test.project_subscription, CONSTRAINT FK_PROJECT_SUBSCRIPTION_PROJECT FOREIGN KEY (project_id) REFERENCES project (id))

Related issue

N/A

Checklist

Things for the developer to confirm they've done before the PR should be accepted:

  • CHANGELOG.md (and UPGRADING.md if necessary) updated with information for new change.
  • Tests added (or description of how to test) for any new features.
  • [ ] User documentation updated for UI or technical changes.

@ksierks ksierks added the bug label Aug 5, 2022
@ksierks ksierks added this to In progress in 22.09 via automation Aug 5, 2022
@ksierks ksierks requested a review from ericenns August 5, 2022 18:17
Copy link
Member

@ericenns ericenns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 This looks good to me, thanks for fixing this.

@ericenns ericenns merged commit edc2d16 into development Aug 5, 2022
22.09 automation moved this from In progress to Done Aug 5, 2022
@ericenns ericenns deleted the fix-delete-project branch August 5, 2022 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
22.09
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants