Skip to content

Commit

Permalink
Add py/pl files to $text_paths (remove l/y files?!)
Browse files Browse the repository at this point in the history
Summary:
I'm guessing this was refactored somewhere down the line and it meant
that Python and Perl files were no longer considered text files.

I'm imagining the old regex was: p(hp|y|l). Therefore I blame CSS.

Test Plan:
Perform an arc lint on a Python or Perl file that has trailing whitespace
on a line. It should prompt you for an autocorrecting lint.

Reviewers: epriestley

Reviewed By: epriestley

CC: aran, Korvin

Differential Revision: https://secure.phabricator.com/D5637
  • Loading branch information
shayne authored and epriestley committed Apr 9, 2013
1 parent dbe0f7d commit cf76d2f
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/lint/engine/ComprehensiveLintEngine.php
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ public function buildLinters() {
}
}

$text_paths = preg_grep('/\.(php|css|hpp|cpp|l|y)$/', $paths);
$text_paths = preg_grep('/\.(php|css|hpp|cpp|l|y|py|pl)$/', $paths);
$linters[] = id(new ArcanistGeneratedLinter())->setPaths($text_paths);
$linters[] = id(new ArcanistNoLintLinter())->setPaths($text_paths);
$linters[] = id(new ArcanistTextLinter())->setPaths($text_paths);
Expand Down

0 comments on commit cf76d2f

Please sign in to comment.