Skip to content

Commit

Permalink
Fix two "msort()" vs "msortv()" issues in "arc land"
Browse files Browse the repository at this point in the history
Summary: See <#242>. Ref T13303. A little more fallout turned up in `arc`.

Test Plan: `grep msort(`

Reviewers: amckinley

Reviewed By: amckinley

Maniphest Tasks: T13303

Differential Revision: https://secure.phabricator.com/D20605
  • Loading branch information
epriestley committed Jun 20, 2019
1 parent 1ef9409 commit d92fa96
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions src/workflow/ArcanistLandWorkflow.php
Original file line number Diff line number Diff line change
Expand Up @@ -1465,7 +1465,7 @@ private function checkForBuildables($diff_phid) {

$console->writeOut($message."\n\n");

$builds = msort($builds, 'getStatusSortVector');
$builds = msortv($builds, 'getStatusSortVector');
foreach ($builds as $build) {
$ansi_color = $build->getStatusANSIColor();
$status_name = $build->getStatusName();
Expand Down Expand Up @@ -1557,7 +1557,7 @@ private function checkForBuildablesWithPlanBehaviors($diff_phid) {
$ongoing_builds = array();
$failed_builds = array();

$builds = msort($builds, 'getStatusSortVector');
$builds = msortv($builds, 'getStatusSortVector');
foreach ($builds as $build_ref) {
$plan = idx($plans, $build_ref->getBuildPlanPHID());
if (!$plan) {
Expand Down

0 comments on commit d92fa96

Please sign in to comment.