Modified msort to msortv #242
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hat said Use msortv(), not msort(), to sort a list which produces vectors.
|
https://secure.phabricator.com/book/phabcontrib/article/contributing_code/#no-pull-requests This fix is correct, but the best way to get stuff like this fixed upstream is to report it on https://discourse.phabricator-community.org. |
|
(I'll shepherd the change into the upstream via the right pathways, please don't sue us.) |
|
I hadn't found the #no-pull-requests instruction, sorry about that. Thanks @epriestley for taking this on. |
|
(Upstream as https://secure.phabricator.com/D20605.) |
phacility-bot
pushed a commit
that referenced
this pull request
Jun 20, 2019
Summary: See <#242>. Ref T13303. A little more fallout turned up in `arc`. Test Plan: `grep msort(` Reviewers: amckinley Reviewed By: amckinley Maniphest Tasks: T13303 Differential Revision: https://secure.phabricator.com/D20605
|
Does anyone has any input on why this started to happen? Is it the harbormaster version? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixed a problem I had - I don't know if this fix is desirable in general, but it solved my problem in this case.
Following from an error message from Harbormaster that said:
Harbormaster failed to build the active diff for this revision.
Exception
msort() was passed a method ("getStatusSortVector") which returns "PhutilSortVector" objects. Use "msortv()", not "msort()", to sort a list which produces vectors.
(Run with
--tracefor a full exception trace.)