-
Notifications
You must be signed in to change notification settings - Fork 273
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Provide ConsoleView classes for "[ OKAY ] Good things happened." cons…
…ole lines Summary: Ref T12996. CLI tools are increasingly standardizing on the output format with a colored "OKAY", "FAIL", "SKIP", "STORAGE UPGRADE", "DEPLOY", etc., in the leftmost column for easy scanning. However, we have like 20 different things that each render it on their own. Add a 21st in libphutil, in hopes that we can have fewer than 21 some day. Test Plan: Used this to render a lint success message in D18645. Reviewers: amckinley Reviewed By: amckinley Maniphest Tasks: T12996 Differential Revision: https://secure.phabricator.com/D18646
- Loading branch information
epriestley
committed
Sep 26, 2017
1 parent
134b16a
commit 63518a5
Showing
6 changed files
with
74 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
<?php | ||
|
||
final class PhutilConsoleError | ||
extends PhutilConsoleLogLine { | ||
|
||
protected function getLogLineColor() { | ||
return 'red'; | ||
} | ||
|
||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
<?php | ||
|
||
final class PhutilConsoleInfo | ||
extends PhutilConsoleLogLine { | ||
|
||
protected function getLogLineColor() { | ||
return 'green'; | ||
} | ||
|
||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,24 @@ | ||
<?php | ||
|
||
abstract class PhutilConsoleLogLine extends PhutilConsoleView { | ||
|
||
private $kind; | ||
private $message; | ||
|
||
abstract protected function getLogLineColor(); | ||
|
||
public function __construct($kind, $message) { | ||
$this->kind = $kind; | ||
$this->message = $message; | ||
} | ||
|
||
protected function drawView() { | ||
$color = $this->getLogLineColor(); | ||
|
||
return tsprintf( | ||
"<bg:".$color.">** %s **</bg> %s\n", | ||
$this->kind, | ||
$this->message); | ||
} | ||
|
||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
<?php | ||
|
||
final class PhutilConsoleSkip | ||
extends PhutilConsoleLogLine { | ||
|
||
protected function getLogLineColor() { | ||
return 'blue'; | ||
} | ||
|
||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
<?php | ||
|
||
final class PhutilConsoleWarning | ||
extends PhutilConsoleLogLine { | ||
|
||
protected function getLogLineColor() { | ||
return 'yellow'; | ||
} | ||
|
||
} |