Fix Ponder Answer query joins, builtins

Summary: Fixes T9234. The joins method was still the old method and the builtin was calling the wrong key. Test Plan: Test authored builtin, custom search Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Maniphest Tasks: T9234 Differential Revision: https://secure.phabricator.com/D13953
phacility · Aug 21, 2015 · ad93af8 · ad93af8
1 parent 22dc3c1
commit ad93af8
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/applications/ponder/query/PonderQuestionQuery.php b/src/applications/ponder/query/PonderQuestionQuery.php
@@ -129,7 +129,7 @@ protected function willFilterPage(array $questions) {
     return $questions;
   }
 
-  private function buildJoinsClause(AphrontDatabaseConnection $conn_r) {
+  protected function buildJoinClauseParts(AphrontDatabaseConnection $conn_r) {
     $joins = array();
 
     if ($this->answererPHIDs) {
@@ -141,7 +141,7 @@ private function buildJoinsClause(AphrontDatabaseConnection $conn_r) {
         $this->answererPHIDs);
     }
 
-    return implode(' ', $joins);
+    return $joins;
   }
 
   protected function getPrimaryTableAlias() {

diff --git a/src/applications/ponder/query/PonderQuestionSearchEngine.php b/src/applications/ponder/query/PonderQuestionSearchEngine.php
@@ -96,7 +96,7 @@ public function buildSavedQueryFromBuiltin($query_key) {
           array($this->requireViewer()->getPHID()));
       case 'answered':
         return $query->setParameter(
-          'answererPHIDs',
+          'answerers',
           array($this->requireViewer()->getPHID()));
     }