D9387: Fix #566: 'PHABRICATOR_USER should be defined' during land to hosted git repo #634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit e8e62f8. Conflicts: src/applications/differential/landing/DifferentialLandingToHostedGit.php Change-Id: I6a37d5d508c5865cc3d724f696f6c5982274229c
The error appears for me on a git repo hosted over http, while another user experiences the same problem with a ssh-served repo: https://github.com/phacility/phabricator/issues/566 The root cause is the following in phabricator/bin/commit-hook: $username = getenv(DiffusionCommitHookEngine::ENV_USER); if (!strlen($username)) { throw new Exception( pht('usage: %s should be defined!', DiffusionCommitHookEngine::ENV_USER)); }
darabi
changed the title
|
Yeah, this isn't the "right" way. I'm not going to pull this into the upstream since I wait to wait until we can build this feature more robustly (this is one of many serious problems you may run into while trying to use it) but it won't break anything if you want to use it locally for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had the same problem as in #566. Also created https://secure.phabricator.com/D9387.
I am aware that this is probably not the correct way of fixing this, but this hack solves my problem.