Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update, Delete Milestones #338

Merged

Conversation

sajidanower23
Copy link
Contributor

  • Adds a data type for updating milestone
  • Adds request functions for updating a milestone
  • Adds request functions for deleting a milestone

Known Issue

As it stands, there is no way the user can say "Remove the due date from my milestone" via the API. UTCTime does not have a Monoid/Semigroup instance either, so I am not sure what the best way to solve this problem is.

@sajidanower23
Copy link
Contributor Author

@phadej any feedback on this? 🙂

@phadej phadej merged commit b8f999f into haskell-github:master Feb 4, 2019
@sajidanower23 sajidanower23 deleted the sajid/update-delete-milestone branch February 6, 2019 05:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants