Make File.fileSha optional. #392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GitHub API for comparing commits returns a null "sha" field when the only change to a file is to its file system permissions. See the following repository for a complete example. https://github.com/scott-fleischman/repo-change-file-permission Example API call: https://api.github.com/repos/scott-fleischman/repo-change-file-permission/compare/80fdf8f83fcd8181411919fbf47394b878c591a0...77a95bbebeb78f4fb25c6a10c3c940b6fe1caa27 Response highlight: ``` "files": [ { "sha": null, "filename": "echo-script", "status": "modified", "additions": 0, "deletions": 0, "changes": 0, "blob_url": "https://github.com/scott-fleischman/repo-change-file-permission/blob/77a95bbebeb78f4fb25c6a10c3c940b6fe1caa27/echo-script", "raw_url": "https://github.com/scott-fleischman/repo-change-file-permission/raw/77a95bbebeb78f4fb25c6a10c3c940b6fe1caa27/echo-script", "contents_url": "https://api.github.com/repos/scott-fleischman/repo-change-file-permission/contents/echo-script?ref=77a95bbebeb78f4fb25c6a10c3c940b6fe1caa27" } ] ```
|
This PR also:
|
phadej
reviewed
Jul 9, 2019
| @@ -188,7 +188,7 @@ data File = File | |||
| , fileStatus :: !Text | |||
| , fileRawUrl :: !(Maybe URL) | |||
| , fileAdditions :: !Int | |||
| , fileSha :: !Text | |||
| , fileSha :: !(Maybe Text) | |||
There was a problem hiding this comment.
related <*> o .: "sha" is better changed to <*> o .:? "sha", except if there is really good reason to require null existence?
There was a problem hiding this comment.
Yes, good call! Fixed in ffed981
|
@phadej is there anything else you would like done on this PR? |
…ha-permission-change Conflicts: samples/github-samples.cabal
|
Looks like you may be back @phadej . Please let me know what I can do to get this change (or a similar one) merged so we can use this project rather than our fork. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub API for comparing commits returns a null "sha" field when the only change to a file is to its file system permissions.
See the following repository for a complete example.
https://github.com/scott-fleischman/repo-change-file-permission
Example API call:
https://api.github.com/repos/scott-fleischman/repo-change-file-permission/compare/80fdf8f83fcd8181411919fbf47394b878c591a0...77a95bbebeb78f4fb25c6a10c3c940b6fe1caa27
Response highlight: