Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getRealSQLStatement and getSQLStatement has no differences #12196

Closed
zhangkx666 opened this issue Sep 3, 2016 · 4 comments
Closed

getRealSQLStatement and getSQLStatement has no differences #12196

zhangkx666 opened this issue Sep 3, 2016 · 4 comments
Labels
documentation Documentation required new feature request Planned Feature or New Feature Request

Comments

@zhangkx666
Copy link

zhangkx666 commented Sep 3, 2016

the source is below.
cphalcon/phalcon/db/adapter.zep

/**
 * Active SQL statement in the object
 */
public function getSQLStatement() -> string
{
    return this->_sqlStatement;
}

/**
 * Active SQL statement in the object without replace bound paramters
 */
public function getRealSQLStatement() -> string
{
    return this->_sqlStatement;
}
@Jurigag
Copy link
Contributor

Jurigag commented Sep 3, 2016

There is no way to return sql statement with replaced bound parameters in PDO. Other than replace them "by hand".

@sergeyklay sergeyklay added this to the 4.0.0 milestone Sep 3, 2016
@Jurigag
Copy link
Contributor

Jurigag commented Mar 3, 2017

I think this could be possibly new feature, it can be done on for 3.2.0. I mean both methods return at this moment the same thing. I thing real sql statement should return sql statement with bound parameters.

@sergeyklay sergeyklay modified the milestones: 3.2.0, 4.0.0 Mar 8, 2017
@sergeyklay sergeyklay modified the milestones: 3.2.0, 4.0.0 Jun 18, 2017
@stale stale bot added the stale Stale issue - automatically closed label Apr 16, 2018
@sergeyklay sergeyklay reopened this May 2, 2018
@stale stale bot removed the stale Stale issue - automatically closed label May 2, 2018
@phalcon phalcon deleted a comment from stale bot Feb 23, 2019
@niden
Copy link
Sponsor Member

niden commented Feb 23, 2019

Closing in favor of #13855. Will revisit if the community votes for it, or in later versions.

@niden niden closed this as completed Feb 23, 2019
@niden niden added the new feature request Planned Feature or New Feature Request label Mar 11, 2019
@niden niden removed this from the 4.0.0 milestone Mar 11, 2019
@niden niden reopened this Mar 11, 2019
@stale stale bot added the stale Stale issue - automatically closed label Jun 9, 2019
@stale stale bot closed this as completed Jun 10, 2019
@phalcon phalcon deleted a comment from stale bot Jun 10, 2019
@niden niden reopened this Jun 10, 2019
niden added a commit that referenced this issue Jan 17, 2020
niden added a commit that referenced this issue Jan 17, 2020
niden added a commit that referenced this issue Jan 17, 2020
niden added a commit that referenced this issue Jan 17, 2020
niden added a commit that referenced this issue Jan 17, 2020
niden added a commit that referenced this issue Jan 17, 2020
@niden
Copy link
Sponsor Member

niden commented Jan 17, 2020

Resolved in #14720

@niden niden closed this as completed Jan 17, 2020
niden added a commit that referenced this issue Feb 4, 2020
niden added a commit that referenced this issue Feb 4, 2020
niden added a commit that referenced this issue Feb 4, 2020
niden added a commit that referenced this issue Feb 4, 2020
niden added a commit that referenced this issue Feb 4, 2020
niden added a commit that referenced this issue Feb 4, 2020
niden added a commit that referenced this issue Feb 4, 2020
niden added a commit that referenced this issue Feb 4, 2020
niden added a commit that referenced this issue Feb 4, 2020
niden added a commit that referenced this issue Feb 4, 2020
niden added a commit that referenced this issue Feb 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Documentation required new feature request Planned Feature or New Feature Request
Projects
Archived in project
Development

No branches or pull requests

4 participants