Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shared lock bug #13529

Closed
TimurFlush opened this issue Oct 16, 2018 · 1 comment
Closed

Shared lock bug #13529

TimurFlush opened this issue Oct 16, 2018 · 1 comment
Assignees
@niden
Labels
bug A bug report status: medium Medium

Comments

@TimurFlush
Copy link

Hello, and...

And I want to tell you about yet another a bug.

Class: Phalcon\Db\Dialect
Method: sharedLock() etc

Note, that the method contains only in abstract class \Phalcon\Db\Dialect, all the dialects not contain specifically the method sharedLock, therefore PostgreSQL can't execute query with LOCK IN SHARE MODE because the operator not supported for PostgreSQL, and only for mysql

Latest Phalcon version.
@niden niden self-assigned this Oct 16, 2018
@niden niden modified the milestones: 4.0.0, 3.4.1 Oct 16, 2018
This was referenced Oct 16, 2018
Merged
Merged
niden added a commit that referenced this issue Oct 18, 2018
@niden
Merge pull request #13533 from niden/T13529-shared-lock-bug-4
e865657 
[#13529] - Moved the sharedLock in the dialects. PostgreSql and Sqlit…
niden added a commit that referenced this issue Oct 18, 2018
@niden
Merge pull request #13532 from niden/T13529-shared-lock-bug
a225614 
[#13529] - Moved the sharedLock in the dialects. PostgreSql and Sqlit…
@niden
Copy link
Sponsor Member

niden commented Oct 18, 2018

Fixed. Thank you for reporting this

@niden niden closed this as completed Oct 18, 2018
@TimurFlush TimurFlush mentioned this issue Oct 19, 2018
Closed
@niden niden added bug A bug report status: medium Medium and removed Bug - Medium labels Dec 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@niden niden

Labels
bug A bug report status: medium Medium
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@niden @TimurFlush