-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
form validation Confirmation strict comparison #15252
Labels
Projects
Comments
Hello! It really seems to be the bug. You can also create your own elements by extending the |
/cc @Izopi4a |
5 tasks
Izopi4a
added a commit
to Izopi4a/cphalcon
that referenced
this issue
Mar 27, 2021
Izopi4a
added a commit
to Izopi4a/cphalcon
that referenced
this issue
Mar 27, 2021
5 tasks
niden
added a commit
that referenced
this issue
Mar 27, 2021
fix #15252 - compare 000012345 and 12345
Resolved with #15347 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Hi guys,
we have a problem using password confirmation validator,
cphalcon/phalcon/Validation/Validator/Confirmation.zep
Line 136 in 3241d96
When we use the confirmation form validation it doesn't consider the type of the data. which is a problem when comparing numbers .
This returns true for
000012345
=12345
it should be either
return strcmp($a, $b) === 0;
or allow us to override the compare method, which we cannot at the moment because of
final protected
thanks
The text was updated successfully, but these errors were encountered: