Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #15252 - compare 000012345 and 12345 #15347

Merged
merged 1 commit into from
Mar 27, 2021
Merged

Conversation

Izopi4a
Copy link
Member

@Izopi4a Izopi4a commented Mar 27, 2021

Hello!

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR
  • I have updated the relevant CHANGELOG
  • I have created a PR for the documentation about this change

Small description of change:

changed how we compare strings in Confirmation validator

Thanks

@codecov
Copy link

codecov bot commented Mar 27, 2021

Codecov Report

❗ No coverage uploaded for pull request base (5.0.x@f49e176). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 084b39d differs from pull request most recent head bceebc8. Consider uploading reports for the commit bceebc8 to get more accurate results

@@           Coverage Diff            @@
##             5.0.x   #15347   +/-   ##
========================================
  Coverage         ?        0           
========================================
  Files            ?        0           
  Lines            ?        0           
  Branches         ?        0           
========================================
  Hits             ?        0           
  Misses           ?        0           
  Partials         ?        0           

@Izopi4a Izopi4a marked this pull request as ready for review March 27, 2021 18:22
@niden niden linked an issue Mar 27, 2021 that may be closed by this pull request
@niden
Copy link
Sponsor Member

niden commented Mar 27, 2021

Thank you @Izopi4a

@niden niden merged commit e7cb50e into phalcon:5.0.x Mar 27, 2021
@niden niden added 5.0 The issues we want to solve in the 5.0 release bug A bug report status: low Low labels Mar 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5.0 The issues we want to solve in the 5.0 release bug A bug report status: low Low
Projects
None yet
Development

Successfully merging this pull request may close these issues.

form validation Confirmation strict comparison
2 participants