Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

volt - text_area & htmlspecialchars #15992

Closed
davidcorreia opened this issue Jun 11, 2022 Discussed in #15991 · 1 comment · Fixed by #15993
Closed

volt - text_area & htmlspecialchars #15992

davidcorreia opened this issue Jun 11, 2022 Discussed in #15991 · 1 comment · Fixed by #15993
Assignees
Labels
5.0 The issues we want to solve in the 5.0 release bug A bug report status: low Low

Comments

@davidcorreia
Copy link

Discussed in #15991

Originally posted by davidcorreia June 11, 2022
I have been testing phalcon v5 (RC1 and just now RC2) with php8.1 and i keep getting warnings like

PHP Deprecated: htmlspecialchars(): Passing null to parameter #1 ($string) of type string is deprecated in /var/www/html/cache/_var_www_html_app_views_index.volt.php on line 453

when i edit the "compiled" file what i see in line 453 is this:
<?= \Phalcon\Tag::textArea(['suggest', 'class' => 'form-control', 'style' => 'height:100px']) ?>
origin code is {{ text_area("suggest", 'class':'form-control', 'style':'height:100px') }}

after i replaced it to simple html the warnings disappeared.
Also if, Tag::setDefault('suggest', ''); is set in the controller, the warning also disappeared.

its a simple workaround, but is it the expected behavior?

@niden niden self-assigned this Jun 11, 2022
@niden niden added 5.0 The issues we want to solve in the 5.0 release bug A bug report status: low Low labels Jun 11, 2022
@niden niden added this to Active Sprint Tasks in Phalcon Roadmap Jun 11, 2022
@niden niden linked a pull request Jun 11, 2022 that will close this issue
5 tasks
@niden
Copy link
Sponsor Member

niden commented Jun 11, 2022

Resolved in #15993

Thank you @davidcorreia

@niden niden closed this as completed Jun 11, 2022
Phalcon Roadmap automation moved this from Active Sprint Tasks to Implemented Jun 11, 2022
@niden niden mentioned this issue Jun 14, 2022
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5.0 The issues we want to solve in the 5.0 release bug A bug report status: low Low
Projects
Archived in project
Phalcon Roadmap
  
Implemented
Development

Successfully merging a pull request may close this issue.

2 participants