Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

T15992 tag htmlspecialchars #15993

Merged
merged 3 commits into from
Jun 11, 2022
Merged

T15992 tag htmlspecialchars #15993

merged 3 commits into from
Jun 11, 2022

Conversation

niden
Copy link
Sponsor Member

@niden niden commented Jun 11, 2022

Hello!

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR
  • I have updated the relevant CHANGELOG
  • I have created a PR for the documentation about this change

Fixed Phalcon\Tag::textArea() to check if the value is null before calling htmlspecialchars

Thanks

@niden niden added bug A bug report status: low Low 5.0 The issues we want to solve in the 5.0 release labels Jun 11, 2022
@niden niden requested a review from Jeckerson June 11, 2022 15:56
@niden niden self-assigned this Jun 11, 2022
@niden niden linked an issue Jun 11, 2022 that may be closed by this pull request
volt - text_area & htmlspecialchars #15992
Closed
@niden niden merged commit c78ecc3 into phalcon:5.0.x Jun 11, 2022
@niden niden deleted the T15992-tag-htmlspecialchars branch June 11, 2022 16:22
@niden niden mentioned this pull request Jun 11, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jeckerson Jeckerson Jeckerson approved these changes

Assignees

@niden niden

Labels
5.0 The issues we want to solve in the 5.0 release bug A bug report status: low Low
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

volt - text_area & htmlspecialchars
2 participants
@niden @Jeckerson