Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

T15992 validation length #15995

Merged
merged 2 commits into from
Jun 15, 2022
Merged

T15992 validation length #15995

merged 2 commits into from
Jun 15, 2022

Conversation

niden
Copy link
Member

@niden niden commented Jun 14, 2022 •
edited
Loading

Hello!

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR
  • I have updated the relevant CHANGELOG
  • I have created a PR for the documentation about this change

Fixed

  • Phalcon/Filter/Validation/Validator/Alnum
  • Phalcon/Filter/Validation/Validator/Alpha
  • Phalcon/Filter/Validation/Validator/Confirmation
  • Phalcon/Filter/Validation/Validator/CreditCard
  • Phalcon/Filter/Validation/Validator/StringLength/Max
  • Phalcon/Filter/Validation/Validator/StringLength/Min

to check if the value is null before calling internal PHP methods

Thanks

@niden niden added bug A bug report status: low Low 5.0 The issues we want to solve in the 5.0 release labels Jun 14, 2022
@niden niden requested a review from Jeckerson June 14, 2022 13:14
@niden niden self-assigned this Jun 14, 2022
@niden niden merged commit c730b4e into phalcon:5.0.x Jun 15, 2022
@niden niden deleted the T15992-validation-length branch June 15, 2022 14:32
@niden niden linked an issue Jun 15, 2022 that may be closed by this pull request
PHP 8.1 deprecation of null arguments #15984
Closed
@niden niden mentioned this pull request Jun 15, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jeckerson Jeckerson Jeckerson approved these changes

Assignees

@niden niden

Labels
5.0 The issues we want to solve in the 5.0 release bug A bug report status: low Low
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PHP 8.1 deprecation of null arguments
2 participants
@niden @Jeckerson