Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NFR]: Refactor short syntax get/set for properties #16102

Closed
niden opened this issue Sep 19, 2022 · 1 comment · Fixed by #16103
Closed

[NFR]: Refactor short syntax get/set for properties #16102

niden opened this issue Sep 19, 2022 · 1 comment · Fixed by #16103
Assignees
@niden
Labels
5.0 The issues we want to solve in the 5.0 release new feature request Planned Feature or New Feature Request

Comments

@niden
Copy link
Sponsor Member

niden commented Sep 19, 2022

Refactor classes to have full getter / setter methods instead of the shorthand ones.

Refactor this

/**
 * @var string
 */
property one "" { get, set };

to this

public function getOne() -> string
{
    return this->one;
}

public function setOne(string value) -> void
{
    let this->one = value;
}
@niden niden added the new feature request Planned Feature or New Feature Request label Sep 19, 2022
niden added a commit to niden/cphalcon that referenced this issue Sep 19, 2022
@niden
[phalcon#16102] - refactoring getters and setters
2e62482
niden added a commit to niden/cphalcon that referenced this issue Sep 19, 2022
@niden
[phalcon#16102] - fixing stubs
8182a1a
@niden niden mentioned this issue Sep 19, 2022
Merged
5 tasks
niden added a commit to niden/cphalcon that referenced this issue Sep 19, 2022
@niden
[phalcon#16102] - updating changelog
26129e8
@Jeckerson Jeckerson linked a pull request Sep 19, 2022 that will close this issue
T16102 get set short #16103
Merged
5 tasks
niden added a commit to niden/cphalcon that referenced this issue Sep 19, 2022
@niden
[phalcon#16102] - renamed property (psr12); better types for register…
f827003 
…edEngines (view)
@niden
Copy link
Sponsor Member Author

niden commented Sep 19, 2022

Resolved in #16103

@niden niden closed this as completed Sep 19, 2022
@niden niden self-assigned this Sep 19, 2022
@niden niden added the 5.0 The issues we want to solve in the 5.0 release label Sep 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@niden niden

Labels
5.0 The issues we want to solve in the 5.0 release new feature request Planned Feature or New Feature Request
Projects
Phalcon v5
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

T16102 get set short niden/cphalcon
1 participant
@niden