Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

T16102 get set short #16103

Merged
merged 4 commits into from
Sep 19, 2022
Merged

T16102 get set short #16103

merged 4 commits into from
Sep 19, 2022

Conversation

niden
Copy link
Sponsor Member

@niden niden commented Sep 19, 2022

Hello!

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR
  • I have updated the relevant CHANGELOG
  • I have created a PR for the documentation about this change

Changed getters and setters from shorthand format to full methods

Thanks

@niden niden added new feature request Planned Feature or New Feature Request 5.0 The issues we want to solve in the 5.0 release labels Sep 19, 2022
@niden niden self-assigned this Sep 19, 2022
@Jeckerson Jeckerson linked an issue Sep 19, 2022 that may be closed by this pull request
[NFR]: Refactor short syntax get/set for properties #16102
Closed
Jeckerson
Jeckerson reviewed Sep 19, 2022
View reviewed changes
phalcon/Mvc/View.zep Outdated Show resolved Hide resolved
@niden niden merged commit 29a9496 into phalcon:5.0.x Sep 19, 2022
@niden niden deleted the T16102-get-set-short branch September 19, 2022 13:35
@niden niden mentioned this pull request Sep 19, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jeckerson Jeckerson Jeckerson approved these changes

Assignees

@niden niden

Labels
5.0 The issues we want to solve in the 5.0 release new feature request Planned Feature or New Feature Request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[NFR]: Refactor short syntax get/set for properties
2 participants
@niden @Jeckerson