Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.0.x] Added options for cookie parameters. Removed DocBlock, and more...х #10085

Closed
wants to merge 1 commit into from

Conversation

KorsaR-ZN
Copy link
Contributor

Update Phalcon\Session\Adapter, Phalcon\Session\AdapterInterface and also full coverage of the tests... And more improvements...

Added public method:

  • getOption()
  • getCookieParams()
  • setCookieParams()
  • setName()
  • getName()
  • regenerateId()
  • reset()
  • commit()
  • abort()
  • clear()
  • status()
  • encode()
  • decode()

Added protected method

  • configure()
  • legacySessionReset()
  • legacySessionAbort()
  • legacySessionStatus()

Added options:

  • name (session name)
  • cookie_lifetime
  • cookie_path
  • cookie_domain
  • cookie_secure
  • cookie_httponly

Phalcon\Session\Adapter\Files added options:

  • savePath

@KorsaR-ZN KorsaR-ZN changed the title Added options for cookie parameters. Removed DocBlock, and more...х [2.0.x] Added options for cookie parameters. Removed DocBlock, and more...х Apr 19, 2015
@Green-Cat
Copy link
Contributor

👍

@KorsaR-ZN KorsaR-ZN force-pushed the NFR-2 branch 2 times, most recently from c819dcb to 6d5fe17 Compare April 19, 2015 20:38
@KorsaR-ZN KorsaR-ZN closed this Apr 19, 2015
@KorsaR-ZN KorsaR-ZN reopened this Apr 19, 2015
@KorsaR-ZN KorsaR-ZN closed this Apr 19, 2015
@KorsaR-ZN KorsaR-ZN reopened this Apr 19, 2015
@KorsaR-ZN KorsaR-ZN force-pushed the NFR-2 branch 3 times, most recently from aede6cd to cd42cf0 Compare April 24, 2015 21:28
@KorsaR-ZN
Copy link
Contributor Author

@andresgutierrez Why not merge?

@andresgutierrez
Copy link
Contributor

Could you please move the CHANGELOG to 2.0.2, also this need rebase

@KorsaR-ZN
Copy link
Contributor Author

@andresgutierrez Rebased

@KorsaR-ZN KorsaR-ZN force-pushed the NFR-2 branch 6 times, most recently from 67162be to 73ce1b9 Compare May 31, 2015 21:58
@KorsaR-ZN
Copy link
Contributor Author

@andresgutierrez Why not merge?

@KorsaR-ZN
Copy link
Contributor Author

@andresgutierrez ping

@KorsaR-ZN KorsaR-ZN force-pushed the NFR-2 branch 3 times, most recently from d45b407 to cd6006c Compare July 1, 2015 06:54
@KorsaR-ZN
Copy link
Contributor Author

@phalcon ping

@KorsaR-ZN
Copy link
Contributor Author

@phalcon, @andresgutierrez
What's the problem with this PR why not merge it?

@KorsaR-ZN KorsaR-ZN force-pushed the NFR-2 branch 4 times, most recently from 9494224 to 680e135 Compare July 23, 2015 17:37
@KorsaR-ZN KorsaR-ZN force-pushed the NFR-2 branch 2 times, most recently from 88f1660 to 323f6c5 Compare August 3, 2015 15:08
@erickskrauch
Copy link

+1

@Green-Cat
Copy link
Contributor

@phalcon Could this be merged please?

@sergeyklay
Copy link
Contributor

@KorsaR-ZN Can you please rebease?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants