Update Phalcon\Mvc\Model return ResultsetInterface #12574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ResultsetInterface is not imported and causes problems when generating Stubs for IDE. It is generating @return type of Phalcon\Mvc\ResultsetInterface and not Phalcon\Mvc\Model\ResultsetInterface I think it should be imported in order to easily find correct class
|
Thanks |
sergeyklay
added a commit
that referenced
this pull request
Feb 25, 2017
* Regenerated build (PHP7) * Regenerated build (PHP5) * Regenerated build (PHP5) * Regenerated build (PHP7) * Using latest Zephir [ci skip] * Bump dev version * Added a number (0) to be a label in a form field. Null, empty string or empty array will keep invalidating a label and using the value instead. * Update CONTRIBUTING.md [ci skip] * Include cipher aliases for \Phalcon\Crypt The older version of Phalcon used aliases for cipher and now they are not available. They are easy to use and migration will be easier if they persist. * Test Alias cipher for \Phalcon\Crypt * Update Changelog * Change test in changelog * Allow other except fields than unique fields * Added backers file * Update tests CHANGELOG.md [ci skip] Add TEST_MC_WEIGHT to export list * Fixed #12567 [ci skip] * Cleaned .gitignorei [ci skip] * Update Phalcon\Mvc\Model return ResultsetInterface (#12574) * Update Phalcon\Mvc\Model return ResultsetInterface ResultsetInterface is not imported and causes problems when generating Stubs for IDE. It is generating @return type of Phalcon\Mvc\ResultsetInterface and not Phalcon\Mvc\Model\ResultsetInterface I think it should be imported in order to easily find correct class * Update CHANGELOG.md * Updated backers file * Fixes #12573 * Updated backers file * Update BACKERS.md with known links * Added mctekk and abits logos * Removing the images to ensure that they are refreshed with the next commit * Re-added the images for backers * Added pdffiller in the backers file * Added links to the BACKERS.md * Updated backers file * Removing the images to ensure that they are refreshed with the next commit * Re-added the images for backers * Added links to the BACKERS.md * Updated backers file * Updated backers file * Updated backers file * Updated backers file * Bump version * Tune up Travis build * Fixed ModelsManager tests * Tune up PHP_CodeSniffer * Tune up PHP_CodeSniffer * Tune up the tests * Updated CHANGELOG.md [ci skip] * Cleaned Gettext::query * Fixed Phalcon\Validation\Message\Group::offsetUnset * Allow role and resource object in isAllowed * Updated backers file * Updated backers file * Updated backers file * Removing the images to ensure that they are refreshed with the next commit * Re-added the images for backers * Added links to the BACKERS.md * Updated Copyright [ci skip] * Updated dependencies * Regenerated build (PHP7) * Regenerated build (PHP5) * Using latest Zephir * Updated CHANGELOG.md [ci skip] * Restarted Travis build * Regenerated build [ci skip] * Regenerating build for php5 [ci skip] * Cleaned Phalcon\Annotations\AdapterInterface * Cleaned the Appveyor Build * Added Phalcon\Validation for Phalcon\Mvc\Collection * install file refactoring, custom phpize & php-config paths allowed * install BINs fix * Rosolved conflicts [ci skip] * Removed unused variables * Amended Uniqueness Validator test * Port Uniquenss Validator changes from 3.0.x * Regenerated build (PHP7) [ci skip] * Regenerated build (PHP5) [ci skip] * Using latest Zephir [ci skip]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
In raising this pull request, I confirm the following:
ResultsetInterface is not imported and causes problems when generating Stubs for IDE. It is generating
@returntype ofPhalcon\Mvc\ResultsetInterfaceand notPhalcon\Mvc\Model\ResultsetInterfaceI think it should be imported in order to easily find the correct class.
Let me know if I am missing something
Thanks