Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleaned up and refactor Volt parser #13755

Merged
merged 6 commits into from Jan 10, 2019
Merged

Cleaned up and refactor Volt parser #13755

merged 6 commits into from Jan 10, 2019

Conversation

sergeyklay
Copy link
Member

Hello!

  • Type: code quality
  • Link to issue: -

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR

Small description of change:

  • Cleaned up and refactor Volt parser
  • Fixed C compiler warnings

Thanks

@sergeyklay sergeyklay added the enhancement Enhancement to the framework label Jan 9, 2019
@sergeyklay sergeyklay self-assigned this Jan 9, 2019
@sergeyklay sergeyklay added this to In progress in 4.0.0 Release via automation Jan 9, 2019
@sergeyklay sergeyklay added this to the 4.0.0 milestone Jan 9, 2019
@codecov
Copy link

codecov bot commented Jan 9, 2019

Codecov Report

Merging #13755 into 4.0.x will decrease coverage by <.01%.
The diff coverage is 76.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##            4.0.x   #13755      +/-   ##
==========================================
- Coverage   65.66%   65.66%   -0.01%     
==========================================
  Files         396      396              
  Lines       88240    88244       +4     
==========================================
+ Hits        57945    57947       +2     
- Misses      30295    30297       +2
Impacted Files Coverage Δ
ext/phalcon/mvc/view/engine/volt/scanner.c 76.47% <ø> (ø) ⬆️
ext/phalcon/mvc/view/engine/volt/parser.c 77.48% <68.42%> (-0.11%) ⬇️
ext/phalcon/mvc/view/engine/volt/parser.php7.inc.h 84.49% <90.9%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e0ab8d...a9a89a1. Read the comment docs.

@sergeyklay sergeyklay merged commit db0ed22 into 4.0.x Jan 10, 2019
4.0.0 Release automation moved this from In progress to Done Jan 10, 2019
@sergeyklay sergeyklay deleted the fix/cleanup-volt-parser branch January 10, 2019 05:58
@niden niden added documentation Documentation required and removed documentation Documentation required labels Apr 9, 2019
@niden niden added the 4.0 label Dec 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement to the framework
Projects
No open projects
4.0.0 Release
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants