Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

T13915 coding standard #13918

Merged
merged 62 commits into from Mar 28, 2019
Merged

T13915 coding standard #13918

merged 62 commits into from Mar 28, 2019

Conversation

niden
Copy link
Sponsor Member

@niden niden commented Mar 28, 2019

Hello!

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR
  • I updated the CHANGELOG

Applying the new coding standard for Phalcon. Certain files have been left untouched intentionally - they will be replaced./refactored later on

Thanks

@niden niden requested a review from sergeyklay March 28, 2019 14:13
@niden niden added the enhancement Enhancement to the framework label Mar 28, 2019
@niden niden added this to In progress in 4.0.0 Release via automation Mar 28, 2019
@niden
Copy link
Sponsor Member Author

niden commented Mar 28, 2019

cc @sergeyklay

@codecov
Copy link

codecov bot commented Mar 28, 2019

Codecov Report

Merging #13918 into 4.0.x will decrease coverage by 0.23%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##            4.0.x   #13918      +/-   ##
==========================================
- Coverage   67.79%   67.55%   -0.24%     
==========================================
  Files         468      468              
  Lines       93291    94027     +736     
==========================================
+ Hits        63246    63523     +277     
- Misses      30045    30504     +459
Impacted Files Coverage Δ
ext/phalcon/exception.zep.c 21.05% <0%> (-78.95%) ⬇️
ext/phalcon/security.zep.c 83.77% <0%> (-6.87%) ⬇️
ext/phalcon/di/injectable.zep.c 65.04% <0%> (-4.96%) ⬇️
ext/phalcon/session/bag.zep.c 82.91% <0%> (-4.76%) ⬇️
ext/phalcon/mvc/model/transaction/manager.zep.c 59.41% <0%> (-2.82%) ⬇️
ext/phalcon/url.zep.c 82.7% <0%> (-2.22%) ⬇️
ext/phalcon/cli/console.zep.c 89.97% <0%> (-2.21%) ⬇️
ext/phalcon/http/cookie.zep.c 50.62% <0%> (-1.77%) ⬇️
ext/phalcon/mvc/application.zep.c 67.13% <0%> (-1.37%) ⬇️
ext/phalcon/mvc/view/simple.zep.c 49.26% <0%> (-1.34%) ⬇️
... and 100 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5af4ca4...fb7b6cb. Read the comment docs.

@niden niden merged commit 5572cec into phalcon:4.0.x Mar 28, 2019
4.0.0 Release automation moved this from In progress to Done Mar 28, 2019
@SidRoberts
Copy link
Contributor

Is there a reason why Phalcon\Application, Phalcon\Cache* didn't get renamed?

@sergeyklay
Copy link
Member

I have no idea :) Well, PRs are always welcome!

@niden
Copy link
Sponsor Member Author

niden commented Mar 29, 2019

@SidRoberts Application it was most likely a mishap.

Cache is going to be rewritten for PSR-16 so no point in renaming it.

@niden niden deleted the T13915-coding-standard branch March 29, 2019 23:43
@SidRoberts
Copy link
Contributor

Fixed in #13920

@niden niden added documentation Documentation required and removed documentation Documentation required labels Apr 9, 2019
@niden niden added the 4.0 label Dec 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement to the framework
Projects
No open projects
4.0.0 Release
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants