Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

T13915 coding standard #13918

Merged
merged 62 commits into from Mar 28, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
62 commits
Select commit Hold shift + click to select a range
a2142a4
[#13915] - Tabs to spaces
niden Mar 22, 2019
74b96cb
[#13915] - Adjusted editorconfig
niden Mar 22, 2019
782a9c8
[#13915] - Work on the property names
niden Mar 22, 2019
29e1391
[#13915] - Changing property names
niden Mar 23, 2019
d59cf22
[#13915] - Changing the di property name
niden Mar 23, 2019
a57fb03
[#13915] - Changed the di variable
niden Mar 23, 2019
136ccf5
Revert "[#13915] - Changed the di variable"
niden Mar 23, 2019
75f1603
Revert "[#13915] - Changing the di property name"
niden Mar 23, 2019
664bbf9
Revert "[#13915] - Changing property names"
niden Mar 23, 2019
1889df2
Revert "[#13915] - Work on the property names"
niden Mar 23, 2019
c9f1f2b
[#13915] - CS work on the annotations classes
niden Mar 23, 2019
ec3b22e
[#13915] - Corrected return value
niden Mar 23, 2019
fde5a7e
[#13915] - Corrected return types
niden Mar 23, 2019
c33030c
[#13915] - CS on Assets
niden Mar 23, 2019
9055952
[#13915] - CS on Config
niden Mar 23, 2019
fed5068
[#13915] - CS on translate, tag, security
niden Mar 23, 2019
d94826f
[#13915] - CS on validation
niden Mar 23, 2019
378fecc
[#13915] - Fixed function exists
niden Mar 23, 2019
018a26a
[#13915] - CS in Forms/Messages
niden Mar 23, 2019
6f4ce2b
[#13915] - Corrected encoding params
niden Mar 23, 2019
64d32c8
[#13915] - Correcting tests
niden Mar 24, 2019
882e14e
[#13915] - CS on Session and Paginator
niden Mar 24, 2019
b380394
[#13915] - CS on Flash, Messages and Image
niden Mar 24, 2019
12f1f0a
[#13915] - Fixes after the merge
niden Mar 24, 2019
35def89
[#13915] - CS on Db
niden Mar 24, 2019
057e1c2
[#13915] - Corerctions on stuff I messed up
niden Mar 24, 2019
504dc3a
[#13915] - Correction for the default in set_state
niden Mar 24, 2019
3f461f1
[#13915] - CS on root classes
niden Mar 24, 2019
9cdfd2e
[#13915] - CS on CLI
niden Mar 24, 2019
b3f0dad
[#13915] - Correcting typos
niden Mar 24, 2019
7bc1775
[#13915] - Changed DI properties
niden Mar 24, 2019
8263dee
[#13915] - Removed beanstalk from sample boxfiles; Fixed handleExcept…
niden Mar 24, 2019
25b6fea
[#13915] - Removed beanstalkd from travis
niden Mar 24, 2019
e3f75b9
[#13915] - CS on Http/Db/Dispatcher
niden Mar 25, 2019
d7d79e9
[#13915] - CS Paginator Model\Query and Builder
niden Mar 25, 2019
6a0ab79
[#13915] - Fixing transactions
niden Mar 25, 2019
df95c60
Revert "[#13915] - Fixing transactions"
niden Mar 25, 2019
d962a6a
Revert "[#13915] - CS Paginator Model\Query and Builder"
niden Mar 25, 2019
d69277c
Revert "[#13915] - CS on Http/Db/Dispatcher"
niden Mar 25, 2019
1e6654b
[#13915] - Work on http
niden Mar 25, 2019
ccddd56
[#13915] - Fixing some tests
niden Mar 25, 2019
6125045
[#13915] - CS on MVC/Http
niden Mar 26, 2019
7f40557
[#13915] - CS on Metadata and fixing tests
niden Mar 26, 2019
1ea22a7
[#13915] - Fixed initialize method
niden Mar 26, 2019
223ab78
[#13915] - CS Image
niden Mar 26, 2019
eb27a51
[#13915] - CS Mvc model
niden Mar 26, 2019
179ed3e
[#13915] - CS Db
niden Mar 26, 2019
f91355c
Revert "[#13915] - CS Db"
niden Mar 26, 2019
406939c
[#13915] - CS Model Query
niden Mar 26, 2019
1fd12d0
[#13915] - CS on Query Builder
niden Mar 26, 2019
2546fcb
[#13915] - Refactor the exception messages
niden Mar 26, 2019
44aa501
[#13915] - CS more refactoring
niden Mar 27, 2019
cc8d4a3
[#13915] - CS Mvc View
niden Mar 27, 2019
c88be40
[#13915] - CS on Mvc View; Corrected tests
niden Mar 27, 2019
4afec2f
[#13915] - CS Router/Annotations
niden Mar 27, 2019
e052e9e
[#13915] - CS Mvc/Router
niden Mar 27, 2019
a49bd2e
[#13915] - CS - Return types; DI
niden Mar 27, 2019
5079c9e
[#13915] - CS/Renaming base classes
niden Mar 27, 2019
5384e9a
[#13915] - CS and renaming
niden Mar 28, 2019
35f5ee0
[#13915] - CS on Resultsets
niden Mar 28, 2019
e362385
[#13915] - Updated Changelog
niden Mar 28, 2019
fb7b6cb
[#13915] - CS on visibility of methods
niden Mar 28, 2019
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
2 changes: 1 addition & 1 deletion .editorconfig
Expand Up @@ -11,7 +11,7 @@ indent_size = 4
charset = utf-8
trim_trailing_whitespace = true

[*.{c,h,awk,w32,bat,mk,Makefile,frag,zep,lemon,re,psm1,sh}]
[*.{c,h,awk,w32,bat,mk,Makefile,frag,lemon,re,psm1,sh}]
indent_style = tab
tab_width = 4

Expand Down
5 changes: 1 addition & 4 deletions .travis.yml
Expand Up @@ -19,7 +19,6 @@ branches:
addons:
apt:
packages:
- beanstalkd
- gdb
- lcov
postgresql: "9.4"
Expand All @@ -40,7 +39,6 @@ cache:

services:
- mysql
- beanstalkd
- mongodb
- redis-server
- postgresql
Expand Down Expand Up @@ -107,8 +105,7 @@ script:
- vendor/bin/codecept build --quiet
- vendor/bin/codecept run --ext DotReporter tests/cli/
- vendor/bin/codecept run --ext DotReporter tests/integration/
- vendor/bin/codecept run tests/unit/
# - vendor/bin/codecept run --ext DotReporter tests/unit/
- vendor/bin/codecept run --ext DotReporter tests/unit/

- .ci/run-volt-tests.sh

Expand Down
1 change: 1 addition & 0 deletions CHANGELOG-4.0.md
Expand Up @@ -32,6 +32,7 @@ The implementation offers PSR-7/PSR-17 compatible components in a different name
## Changed
- Refactored `Phalcon\Registry` to use the `Phalcon\Collection` class [#13893](https://github.com/phalcon/cphalcon/issues/13893)
- Refactored `Phalcon\Session\Bag` to use the `Phalcon\Collection` class [#13893](https://github.com/phalcon/cphalcon/issues/13893)
- Refactored almost all files of the project to abide by the new coding standard for Phalcon. Certain files have been intentionally left untouched because they will be relaced later on. [#13915](https://github.com/phalcon/cphalcon/issues/13915)

## Removed
- Removed `Phalcon\Session\BagInterface` [#13893](https://github.com/phalcon/cphalcon/issues/13893)
Expand Down
5 changes: 2 additions & 3 deletions phalcon/acl.zep → phalcon/Acl.zep
Expand Up @@ -58,7 +58,6 @@ namespace Phalcon;
*/
abstract class Acl
{
const ALLOW = 1;

const DENY = 0;
const ALLOW = 1;
const DENY = 0;
}
93 changes: 93 additions & 0 deletions phalcon/Acl/Adapter.zep
@@ -0,0 +1,93 @@

/**
* This file is part of the Phalcon Framework.
*
* (c) Phalcon Team <team@phalconphp.com>
*
* For the full copyright and license information, please view the LICENSE.txt
* file that was distributed with this source code.
*/

namespace Phalcon\Acl;

use Phalcon\Events\ManagerInterface;
use Phalcon\Events\EventsAwareInterface;

/**
* Phalcon\Acl\Adapter
*
* Adapter for Phalcon\Acl adapters
*/
abstract class Adapter implements AdapterInterface, EventsAwareInterface
{
/**
* Active access which the list is checking if some role can access it
*
* @var string
*/
protected activeAccess { get };

/**
* Access Granted
* @var bool
*/
protected accessGranted = false;

/**
* Role which the list is checking if it's allowed to certain component/access
*
* @var string
*/
protected activeRole { get };

/**
* Component which the list is checking if some role can access it
*
* @var string
*/
protected activeComponent { get };

/**
* Default access
* @var bool
*/
protected defaultAccess = false;

/**
* Events manager
* @var mixed
*/
protected eventsManager;

/**
* Returns the default ACL access level
*/
public function getDefaultAction() -> int
{
return this->defaultAccess;
}

/**
* Returns the internal event manager
*/
public function getEventsManager() -> <ManagerInterface>
{
return this->eventsManager;
}

/**
* Sets the default access level (Phalcon\Acl::ALLOW or Phalcon\Acl::DENY)
*/
public function setDefaultAction(int defaultAccess)
{
let this->defaultAccess = defaultAccess;
}

/**
* Sets the events manager
*/
public function setEventsManager(<ManagerInterface> eventsManager) -> void
{
let this->eventsManager = eventsManager;
}
}