Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored Timestampable model behavior. #14027

Merged
merged 1 commit into from
May 9, 2019
Merged

Refactored Timestampable model behavior. #14027

merged 1 commit into from
May 9, 2019

Conversation

SidRoberts
Copy link
Contributor

@SidRoberts SidRoberts commented Apr 30, 2019

Hello!

  • Type: code quality
  • Link to issue:

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • [-] I wrote some tests for this PR
  • [-] I updated the CHANGELOG

Quick question: Why would anyone want to update multiple fields with the same timestamp? Could we remove this functionality?

@codecov
Copy link

codecov bot commented Apr 30, 2019

Codecov Report

Merging #14027 into 4.0.x will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##            4.0.x   #14027      +/-   ##
==========================================
+ Coverage   68.62%   68.62%   +<.01%     
==========================================
  Files         470      470              
  Lines       95148    95158      +10     
==========================================
+ Hits        65294    65301       +7     
- Misses      29854    29857       +3
Impacted Files Coverage Δ
ext/phalcon/mvc/model/behavior/timestampable.zep.c 65.75% <0%> (+0.67%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d4e2f1...eb63c84. Read the comment docs.

Jeckerson
Jeckerson previously approved these changes Apr 30, 2019
@sergeyklay
Copy link
Contributor

@SidRoberts Is it ready to merge

@sergeyklay
Copy link
Contributor

N.B. Could you create a new issue for "Quick question" to allow other contributors a chance to speak up, and to take a fresh look at this issue later.

@SidRoberts
Copy link
Contributor Author

@sergeyklay It is ready.

@sergeyklay
Copy link
Contributor

@SidRoberts Could you please rebase

@niden niden merged commit 03a04b7 into phalcon:4.0.x May 9, 2019
@niden
Copy link
Sponsor Member

niden commented May 9, 2019

Thank you @SidRoberts

@niden niden added the enhancement Enhancement to the framework label May 12, 2019
@niden niden added this to In progress in 4.0.0 Release via automation May 12, 2019
@niden niden moved this from In progress to Done in 4.0.0 Release May 12, 2019
@niden niden added the 4.0 label Dec 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement to the framework
Projects
No open projects
4.0.0 Release
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants