Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mvc\Model::__get() / __set() and related storage #14035

Merged
merged 53 commits into from
May 11, 2019
Merged

Mvc\Model::__get() / __set() and related storage #14035

merged 53 commits into from
May 11, 2019

Commits on Apr 16, 2019

  1. Merge pull request #5 from phalcon/4.0.x 

    4.0.x
    @zsilbi
    zsilbi committed Apr 16, 2019
    Configuration menu
    Copy the full SHA
    c57d12e View commit details
    Browse the repository at this point in the history

Commits on Apr 23, 2019

  1. Merge pull request #6 from phalcon/4.0.x 

    4.0.x
    @zsilbi
    zsilbi committed Apr 23, 2019
    Configuration menu
    Copy the full SHA
    61647f4 View commit details
    Browse the repository at this point in the history

Commits on Apr 26, 2019

  1. Merge pull request #7 from phalcon/4.0.x 

    4.0.x
    @zsilbi
    zsilbi committed Apr 26, 2019
    Configuration menu
    Copy the full SHA
    78a533a View commit details
    Browse the repository at this point in the history

Commits on Apr 30, 2019

  1. Merge pull request #8 from phalcon/4.0.x 

    4.0.x
    @zsilbi
    zsilbi committed Apr 30, 2019
    Configuration menu
    Copy the full SHA
    376b359 View commit details
    Browse the repository at this point in the history

Commits on May 2, 2019

  1. Merge pull request #9 from phalcon/4.0.x 

    4.0.x
    @zsilbi
    zsilbi committed May 2, 2019
    Configuration menu
    Copy the full SHA
    ba010c9 View commit details
    Browse the repository at this point in the history

  2. Added tests for Mvc\Model::isRelationShipLoaded() 

    Added tests for Mvc\Model::save()
Added tests for Mvc\Model::__set()
Added tests for Mvc\Model::writeAttribute()
    Németh Balázs committed May 2, 2019
    Configuration menu
    Copy the full SHA
    1cd7b8b View commit details
    Browse the repository at this point in the history

  3. Added aliases to some test models

    Németh Balázs committed May 2, 2019
    Configuration menu
    Copy the full SHA
    68085bd View commit details
    Browse the repository at this point in the history

  4. Removed storing related records in class properties 

    Added new related storages
Modified __set(), __get(), getRelated() to use these related storages
Modified save() to use these related storages with transaction handling
Modified _getRelatedRecords() to use getRelated() when possible
Reusable relations now cached and returned from the Model directly
Non-reusable relation are not cached
Fixed __set() to handle arrays correctly
    Németh Balázs committed May 2, 2019
    Configuration menu
    Copy the full SHA
    35ed4e6 View commit details
    Browse the repository at this point in the history

  5. Added delete to save() test to prevent Paginator\QueryBuilder test error

    Németh Balázs committed May 2, 2019
    Configuration menu
    Copy the full SHA
    922679a View commit details
    Browse the repository at this point in the history

Commits on May 3, 2019

  1. Code style

    Németh Balázs committed May 3, 2019
    Configuration menu
    Copy the full SHA
    de4d0b6 View commit details
    Browse the repository at this point in the history

  2. Changed assigning values to a referenced model to use assign()

    Németh Balázs committed May 3, 2019
    Configuration menu
    Copy the full SHA
    11f507b View commit details
    Browse the repository at this point in the history

  3. Segfault fix 

    See: zephir-lang/zephir#1855
    Németh Balázs committed May 3, 2019
    Configuration menu
    Copy the full SHA
    44696e7 View commit details
    Browse the repository at this point in the history

Commits on May 5, 2019

  1. Update libmemcached.zep 

    Added missing comments
    @ruudboon
    ruudboon authored and Németh Balázs committed May 5, 2019
    Configuration menu
    Copy the full SHA
    c7b5af5 View commit details
    Browse the repository at this point in the history

  2. Regenrated ext

    @sergeyklay
    sergeyklay authored and Németh Balázs committed May 5, 2019
    Configuration menu
    Copy the full SHA
    e11b64b View commit details
    Browse the repository at this point in the history

  3. [WIP] Added variable types. (phalcon#14015) 

    * Added variable types.

* Whitespace.

* Improved logic.
    @SidRoberts
    SidRoberts authored and Németh Balázs committed May 5, 2019
    Configuration menu
    Copy the full SHA
    ad2d2f7 View commit details
    Browse the repository at this point in the history

  4. Fixed the non-array return value in Flash\Session::getSessionMessages()

    Németh Balázs committed May 5, 2019
    Configuration menu
    Copy the full SHA
    e0a605d View commit details
    Browse the repository at this point in the history

  5. Fixed the non-array return value in Flash\Session::getSessionMessages()

    Németh Balázs committed May 5, 2019
    Configuration menu
    Copy the full SHA
    f2f0f88 View commit details
    Browse the repository at this point in the history

  6. Code style fix

    Németh Balázs committed May 5, 2019
    Configuration menu
    Copy the full SHA
    82f17ef View commit details
    Browse the repository at this point in the history

  7. Modified test

    Németh Balázs committed May 5, 2019
    Configuration menu
    Copy the full SHA
    73b3dd5 View commit details
    Browse the repository at this point in the history

  8. Added classes

    Németh Balázs committed May 5, 2019
    Configuration menu
    Copy the full SHA
    afdfac5 View commit details
    Browse the repository at this point in the history

  9. Tidied up tests.

    @SidRoberts
    SidRoberts authored and Németh Balázs committed May 5, 2019
    Configuration menu
    Copy the full SHA
    a738e02 View commit details
    Browse the repository at this point in the history

  10. Tidied up optimizers.

    @SidRoberts
    SidRoberts authored and Németh Balázs committed May 5, 2019
    Configuration menu
    Copy the full SHA
    c9e3315 View commit details
    Browse the repository at this point in the history

  11. Fixed Phalcon\Config\Adapter\Ini() to handle arrays correctly (phalco… 

    …n#14026)

* Fixeing Config\Adapter\Ini notices when casting arrays

* Fixed Phalcon\Config\Adapter\Ini() to handle arrays correctly

* Update tests/_data/assets/config/config-with-constants.ini

Co-Authored-By: zsilbi <zsilbi@users.noreply.github.com>

* Fixeing Config\Adapter\Ini notices when casting arrays

* Fixed Phalcon\Config\Adapter\Ini() to handle arrays correctly
    @zsilbi
    zsilbi authored and Németh Balázs committed May 5, 2019
    Configuration menu
    Copy the full SHA
    ffa4447 View commit details
    Browse the repository at this point in the history

  12. Fixed PHPDoc code example in session/adapter/files

    @Jeckerson
    Jeckerson authored and Németh Balázs committed May 5, 2019
    Configuration menu
    Copy the full SHA
    11648de View commit details
    Browse the repository at this point in the history

  13. Added tests for Mvc\Model::isRelationShipLoaded() 

    Added tests for Mvc\Model::save()
Added tests for Mvc\Model::__set()
Added tests for Mvc\Model::writeAttribute()
    Németh Balázs committed May 5, 2019
    Configuration menu
    Copy the full SHA
    b4accd8 View commit details
    Browse the repository at this point in the history

  14. Added aliases to some test models

    Németh Balázs committed May 5, 2019
    Configuration menu
    Copy the full SHA
    013d929 View commit details
    Browse the repository at this point in the history

  15. Removed storing related records in class properties 

    Added new related storages
Modified __set(), __get(), getRelated() to use these related storages
Modified save() to use these related storages with transaction handling
Modified _getRelatedRecords() to use getRelated() when possible
Reusable relations now cached and returned from the Model directly
Non-reusable relation are not cached
Fixed __set() to handle arrays correctly
    Németh Balázs committed May 5, 2019
    Configuration menu
    Copy the full SHA
    385a405 View commit details
    Browse the repository at this point in the history

  16. Added delete to save() test to prevent Paginator\QueryBuilder test error

    Németh Balázs committed May 5, 2019
    Configuration menu
    Copy the full SHA
    bf12b3d View commit details
    Browse the repository at this point in the history

  17. Code style

    Németh Balázs committed May 5, 2019
    Configuration menu
    Copy the full SHA
    4a3c610 View commit details
    Browse the repository at this point in the history

  18. Changed assigning values to a referenced model to use assign()

    Németh Balázs committed May 5, 2019
    Configuration menu
    Copy the full SHA
    16d4b8a View commit details
    Browse the repository at this point in the history

  19. Segfault fix 

    See: zephir-lang/zephir#1855
    Németh Balázs committed May 5, 2019
    Configuration menu
    Copy the full SHA
    f65b00c View commit details
    Browse the repository at this point in the history

  20. Typo in comment

    Németh Balázs committed May 5, 2019
    Configuration menu
    Copy the full SHA
    7927111 View commit details
    Browse the repository at this point in the history

  21. Fixed asserts

    Németh Balázs committed May 5, 2019
    Configuration menu
    Copy the full SHA
    3882df1 View commit details
    Browse the repository at this point in the history

  22. Merge remote-tracking branch 'origin/model-relation-storage-with-test… 

    …s' into model-relation-storage-with-tests

# Conflicts:
#	phalcon/Mvc/Model.zep
#	tests/integration/Mvc/Model/SaveCest.php
#	tests/integration/Mvc/Model/UnderscoreSetCest.php
    Németh Balázs committed May 5, 2019
    Configuration menu
    Copy the full SHA
    3191bd1 View commit details
    Browse the repository at this point in the history

  23. Changed writeAttribute test to actually use Model::writeAttribute()

    Németh Balázs committed May 5, 2019
    Configuration menu
    Copy the full SHA
    b36bfba View commit details
    Browse the repository at this point in the history

  24. Only unfiltered related records should be cached in Model.

    Németh Balázs committed May 5, 2019
    Configuration menu
    Copy the full SHA
    f6e0aec View commit details
    Browse the repository at this point in the history

Commits on May 6, 2019

  1. Removed Model::relatedSaved[] 

    Saved related records should always be returned as Resultset
Renamed Model::relatedUnsaved[] to Model::dirtyRelated[]
    Németh Balázs committed May 6, 2019
    Configuration menu
    Copy the full SHA
    d078620 View commit details
    Browse the repository at this point in the history

  2. Moved returning dirty related records to __get() 

    Modified isRelationshipLoaded() and updated tests
Added docs to isRelationshipLoaded()
Removed unused variable: related
Fixed comments
    Németh Balázs committed May 6, 2019
    Configuration menu
    Copy the full SHA
    35a3bd6 View commit details
    Browse the repository at this point in the history

  3. Typo fix

    Németh Balázs committed May 6, 2019
    Configuration menu
    Copy the full SHA
    e4e65fd View commit details
    Browse the repository at this point in the history

  4. Tests for Model::__get()

    Németh Balázs committed May 6, 2019
    Configuration menu
    Copy the full SHA
    8002ecd View commit details
    Browse the repository at this point in the history

  5. Removed whitespace

    Németh Balázs committed May 6, 2019
    Configuration menu
    Copy the full SHA
    6eb8498 View commit details
    Browse the repository at this point in the history

  6. Added tests for Model::getRelated()

    Németh Balázs committed May 6, 2019
    Configuration menu
    Copy the full SHA
    698e0a2 View commit details
    Browse the repository at this point in the history

  7. Whitespace removed

    Németh Balázs committed May 6, 2019
    Configuration menu
    Copy the full SHA
    cf8154b View commit details
    Browse the repository at this point in the history

  8. Added test model aliases

    Németh Balázs committed May 6, 2019
    Configuration menu
    Copy the full SHA
    efeea68 View commit details
    Browse the repository at this point in the history

  9. Model::getRelated() return hint fixed

    Németh Balázs committed May 6, 2019
    Configuration menu
    Copy the full SHA
    c75a23d View commit details
    Browse the repository at this point in the history

  10. Fixed asserts

    Németh Balázs committed May 6, 2019
    Configuration menu
    Copy the full SHA
    5b89327 View commit details
    Browse the repository at this point in the history

  11. Typo

    Németh Balázs committed May 6, 2019
    Configuration menu
    Copy the full SHA
    230654d View commit details
    Browse the repository at this point in the history

  12. Fixed asserts

    Németh Balázs committed May 6, 2019
    Configuration menu
    Copy the full SHA
    b50c4e9 View commit details
    Browse the repository at this point in the history

  13. ModelInterface::getRelated() return hint fixed

    Németh Balázs committed May 6, 2019
    Configuration menu
    Copy the full SHA
    0c49716 View commit details
    Browse the repository at this point in the history

Commits on May 7, 2019

  1. Code style

    Németh Balázs committed May 7, 2019
    Configuration menu
    Copy the full SHA
    25cb1cf View commit details
    Browse the repository at this point in the history

  2. Code style again

    Németh Balázs committed May 7, 2019
    Configuration menu
    Copy the full SHA
    f5e5e18 View commit details
    Browse the repository at this point in the history

  3. Code style again..

    Németh Balázs committed May 7, 2019
    Configuration menu
    Copy the full SHA
    7d7fc65 View commit details
    Browse the repository at this point in the history

  4. Changelog updated

    Németh Balázs committed May 7, 2019
    Configuration menu
    Copy the full SHA
    d90459b View commit details
    Browse the repository at this point in the history