Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

T14515 annotataions stream #14517

Merged
merged 3 commits into from Nov 6, 2019
Merged

T14515 annotataions stream #14517

merged 3 commits into from Nov 6, 2019

Conversation

niden
Copy link
Sponsor Member

@niden niden commented Nov 6, 2019

Hello!

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR
  • I have updated the relevant CHANGELOG
  • I have created a PR for the documentation about this change

Fixed Phalcon\Annotations\Adapter\Stream::read and Phalcon\Annotations\Adapter\Stream::write to use serialize/unserialize vs. var_export

Thanks

@niden niden added 4.0 labels Nov 6, 2019
@niden niden added this to In progress in 4.0.0 Release via automation Nov 6, 2019
sergeyklay
sergeyklay previously approved these changes Nov 6, 2019
@codecov
Copy link

codecov bot commented Nov 6, 2019

Codecov Report

Merging #14517 into 4.0.x will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##            4.0.x   #14517      +/-   ##
==========================================
+ Coverage   67.69%   67.71%   +0.01%     
==========================================
  Files         482      482              
  Lines      111775   111796      +21     
==========================================
+ Hits        75670    75703      +33     
+ Misses      36105    36093      -12

@niden niden merged commit 8bf1818 into phalcon:4.0.x Nov 6, 2019
4.0.0 Release automation moved this from In progress to Done Nov 6, 2019
@niden niden deleted the T14515-annotataions-stream branch November 6, 2019 20:37
@niden niden added bug A bug report status: medium Medium and removed Bug - Medium labels Dec 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A bug report status: medium Medium
Projects
No open projects
4.0.0 Release
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants