Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#14862 - Swap condition if column allows null values in PostgreSQL #14876

Merged
merged 25 commits into from
Feb 27, 2020
Merged

#14862 - Swap condition if column allows null values in PostgreSQL #14876

merged 25 commits into from
Feb 27, 2020

Conversation

Jeckerson
Copy link
Member

@Jeckerson Jeckerson commented Feb 25, 2020 •
edited
Loading

Hello!

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR
  • I have updated the relevant CHANGELOG
  • I have created a PR for the documentation about this change

Small description of change:

Thanks

@Jeckerson Jeckerson added bug A bug report status: medium Medium 4.0.5 labels Feb 25, 2020
@Jeckerson Jeckerson self-assigned this Feb 25, 2020
@Jeckerson Jeckerson linked an issue Feb 25, 2020 that may be closed by this pull request
[BUG]: Model - Update - Postgres NULL value is not allowed on Phalcon 4.0.4 #14862
Closed
@Jeckerson
#14862 - Enable CI step to run database tests with Postgres
104a767
@Jeckerson
#14862 - Add 'pgsql' group for some tests
ec9b51a
@Jeckerson
#14862 - Rename 'private' schema to 'public'
375bf79
@Jeckerson
#14862 - Add debug info of env variable
7113119
@Jeckerson
#14862 - Rename 'private' schema to 'public'
e35f9eb
@Jeckerson
#14862 - Rename 'private' schema to 'public'
ae3b985
@Jeckerson
#14862 - Rename 'private' schema to 'public'
73b88a6
@Jeckerson
#14862 - Rename 'private' schema to 'public'
054d1f6
@Jeckerson
#14862 - Review private/public schemas
ef7b797
@Jeckerson
#14862 - Rename 'public' schema to 'private'
1ac8a31
@Jeckerson
#14862 - Add IF EXISTS
ccdaf82
@Jeckerson
#14862 - Clean debug code
b8681da
@Jeckerson
#14862 - Add env variable DATA_POSTGRES_USER in Postgres tests
f29776f
@Jeckerson
#14862 - Set POSTGRES_USER to default 'postgres'
89637da
@Jeckerson
#14862 - Fix postgresql driver name
df71cf1
@Jeckerson
#14862 - Refactor method clear() by adding support of Postgres
f59d6cb
@Jeckerson
#14862 - Remove 'initial_queries' step
f5d07a0
@Jeckerson
#14862 - Update CustomersMigration and InvoicesMigration postgres que…
6cceb59 
…ries
@Jeckerson
#14862 - Update tests for postgres group
7976dcb
@Jeckerson
#14862 - Update schemas
3bf9412
@Jeckerson
#14862 - Change value of 'inv_id' key
4015877
@Jeckerson Jeckerson marked this pull request as ready for review February 26, 2020 00:08
@Jeckerson Jeckerson added this to Working on it in Phalcon Roadmap Feb 26, 2020
@Jeckerson Jeckerson changed the title #14862 - Swap condition if column allows null values #14862 - Swap condition if column allows null values in PostgreSQL Feb 26, 2020
sergeyklay
sergeyklay previously approved these changes Feb 26, 2020
View reviewed changes
Copy link
Member

@sergeyklay sergeyklay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ruudboon
ruudboon previously approved these changes Feb 26, 2020
View reviewed changes
Copy link
Member

@ruudboon ruudboon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@jenovateurs jenovateurs mentioned this pull request Feb 26, 2020
Merged
5 tasks
@Jeckerson
Merge branch '4.0.x' into fix/#14862-pgsql-null-columns
a4b3b63 
# Conflicts:
#	tests/_data/assets/schemas/pgsql.sql
#	tests/_data/fixtures/Migrations/OrdersProductsMigration.php
#	tests/_envs/pgsql.yml
@Jeckerson
#14862 - Remove condition if table exists
6384c54
@Jeckerson Jeckerson dismissed stale reviews from ruudboon and sergeyklay via 6384c54 February 26, 2020 20:46
jenovateurs
jenovateurs previously approved these changes Feb 26, 2020
View reviewed changes
@Jeckerson Jeckerson merged commit d15ae7a into 4.0.x Feb 27, 2020
Phalcon Roadmap automation moved this from Working on it to Implemented Feb 27, 2020
@Jeckerson Jeckerson deleted the fix/#14862-pgsql-null-columns branch February 27, 2020 06:53
@Jeckerson Jeckerson mentioned this pull request Feb 27, 2020
Closed
@niden niden moved this from Implemented to Released in Phalcon Roadmap Mar 7, 2020
@zsilbi zsilbi mentioned this pull request Oct 20, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sergeyklay sergeyklay sergeyklay approved these changes

@jenovateurs jenovateurs jenovateurs left review comments

@niden niden Awaiting requested review from niden

@ruudboon ruudboon Awaiting requested review from ruudboon

Assignees

@Jeckerson Jeckerson

Labels
bug A bug report status: medium Medium
Projects
Phalcon v5
Archived in project
Phalcon Roadmap
  
Released
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG]: Model - Update - Postgres NULL value is not allowed on Phalcon 4.0.4
4 participants
@Jeckerson @sergeyklay @jenovateurs @ruudboon