Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHP 8 compile test #15287

Merged
merged 94 commits into from Mar 23, 2021
Merged

PHP 8 compile test #15287

merged 94 commits into from Mar 23, 2021

Conversation

Jeckerson
Copy link
Member

@Jeckerson Jeckerson commented Feb 10, 2021 •
edited

Hello!

  • Type: bug fix | new feature | code quality | documentation
  • Link to issue:

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR
  • I have updated the relevant CHANGELOG
  • I have created a PR for the documentation about this change

Small description of change:

Thanks

@Jeckerson Jeckerson changed the title Php 8 compile test PHP 8 compile test Feb 10, 2021
@Jeckerson Jeckerson mentioned this pull request Feb 10, 2021
Merged
pgalocha
pgalocha previously approved these changes Feb 11, 2021
View reviewed changes
@Jeckerson Jeckerson mentioned this pull request Mar 14, 2021
Closed
@Jeckerson Jeckerson marked this pull request as ready for review March 23, 2021 19:10
@Jeckerson Jeckerson requested a review from niden March 23, 2021 19:48
@niden niden merged commit ccf06a4 into 4.2.x Mar 23, 2021
@niden niden added 5.0 The issues we want to solve in the 5.0 release bug A bug report status: medium Medium labels Mar 23, 2021
@niden niden deleted the php-8-compile-test branch March 23, 2021 20:03
@Jeckerson Jeckerson mentioned this pull request May 8, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@niden niden niden approved these changes

@pgalocha pgalocha pgalocha left review comments

Assignees
No one assigned
Labels
5.0 The issues we want to solve in the 5.0 release bug A bug report status: medium Medium
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Jeckerson @niden @pgalocha @AlexNDRmac