Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

T15240 igbinary serialize numbers #15342

Merged
merged 5 commits into from
Mar 26, 2021
Merged

T15240 igbinary serialize numbers #15342

merged 5 commits into from
Mar 26, 2021

Conversation

niden
Copy link
Sponsor Member

@niden niden commented Mar 26, 2021

Hello!

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR
  • I have updated the relevant CHANGELOG
  • I have created a PR for the documentation about this change

Small description of change:

Corrected igbinary serailzer to handle is_numeric and bool values properly

@niden niden added 5.0 The issues we want to solve in the 5.0 release bug A bug report status: medium Medium labels Mar 26, 2021
@niden niden linked an issue Mar 26, 2021 that may be closed by this pull request
[BUG]: Phalcon\Storage\Serializer\Igbinary not saving is_numeric()/bool values #15240
Closed
@niden niden merged commit 477b6a5 into phalcon:5.0.x Mar 26, 2021
@niden niden deleted the T15240-igbinary-serialize-numbers branch March 26, 2021 20:56
@niden niden mentioned this pull request Mar 26, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jeckerson Jeckerson Jeckerson approved these changes

Assignees
No one assigned
Labels
5.0 The issues we want to solve in the 5.0 release bug A bug report status: medium Medium
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG]: Phalcon\Storage\Serializer\Igbinary not saving is_numeric()/bool values
2 participants
@niden @Jeckerson