-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixing Flash\Session::has() returning always true #15353
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jeckerson
reviewed
Mar 30, 2021
niden
added
5.0
The issues we want to solve in the 5.0 release
bug
A bug report
status: low
Low
labels
Mar 30, 2021
niden
previously approved these changes
Mar 30, 2021
niden
dismissed
their stale review
March 30, 2021 16:35
Something is wrong with the tests - the code looks OK
Izopi4a
changed the title
fixing Flash\Session::has() returning always true
[WIP] fixing Flash\Session::has() returning always true
Mar 30, 2021
i will check to see what is wrong, probably i broke something , changed the MR name to wip |
ok, so if the declarion in zephir is as followed:
|
Izopi4a
changed the title
[WIP] fixing Flash\Session::has() returning always true
fixing Flash\Session::has() returning always true
Mar 30, 2021
@Izopi4a Yep, just simulated in Zephir. For now we can specify |
Jeckerson
approved these changes
Mar 30, 2021
niden
approved these changes
Mar 31, 2021
Fixes #15353 (review) @Izopi4a Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
In raising this pull request, I confirm the following:
Small description of change:
I am basically reverting the changes on Flash\Session::has() from this PR https://github.com/phalcon/cphalcon/pull/13994/files
I don't agree with the way funtion is changed, feels like just a bug
Thanks