Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

T15494 sessionbag init #15706

Merged
merged 3 commits into from
Oct 3, 2021
Merged

T15494 sessionbag init #15706

merged 3 commits into from
Oct 3, 2021

Conversation

niden
Copy link
Sponsor Member

@niden niden commented Oct 2, 2021

Hello!

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR
  • I have updated the relevant CHANGELOG
  • I have created a PR for the documentation about this change

Changed Phalcon\Session\Bag::construct to accept a container instead of internally calling the default
Changed Phalcon\Session\Bag::construct to throw an exception if the container is not specified
Changed Phalcon\Session\Bag::init to store the data in the session [#15494]

Thanks

@niden niden added new feature request Planned Feature or New Feature Request breaks bc Functionality that breaks Backwards Compatibility 5.0 The issues we want to solve in the 5.0 release labels Oct 2, 2021
@niden niden self-assigned this Oct 2, 2021
@niden niden linked an issue Oct 2, 2021 that may be closed by this pull request
[NFR]: Using init() on session bag should store data in session #15494
Closed
@niden niden merged commit d8cc422 into phalcon:5.0.x Oct 3, 2021
@niden niden deleted the T15494-sessionbag-init branch October 3, 2021 14:37
@niden niden mentioned this pull request Oct 3, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jeckerson Jeckerson Jeckerson approved these changes

Assignees

@niden niden

Labels
5.0 The issues we want to solve in the 5.0 release breaks bc Functionality that breaks Backwards Compatibility new feature request Planned Feature or New Feature Request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[NFR]: Using init() on session bag should store data in session
2 participants
@niden @Jeckerson