Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

T15726 align flash filter #15734

Merged
merged 13 commits into from
Oct 24, 2021
Merged

T15726 align flash filter #15734

merged 13 commits into from
Oct 24, 2021

Conversation

niden
Copy link
Sponsor Member

@niden niden commented Oct 24, 2021

Hello!

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR
  • I have updated the relevant CHANGELOG
  • I have created a PR for the documentation about this change

Aligned Flash with phalcon repository; more tests
Moved Filter to the Filter namespace; more tests; minor refactoring

Thanks

@niden niden requested a review from Jeckerson October 24, 2021 09:37
@niden niden self-assigned this Oct 24, 2021
@niden niden added 5.0 The issues we want to solve in the 5.0 release new feature request Planned Feature or New Feature Request labels Oct 24, 2021
@niden niden merged commit 9c64261 into phalcon:5.0.x Oct 24, 2021
@niden niden deleted the T15726-align-flash-filter branch October 24, 2021 14:51
@niden niden mentioned this pull request Oct 24, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jeckerson Jeckerson Jeckerson approved these changes

Assignees

@niden niden

Labels
5.0 The issues we want to solve in the 5.0 release new feature request Planned Feature or New Feature Request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@niden @Jeckerson