Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

T15801 remove tag 2 #15833

Merged
merged 13 commits into from
Dec 20, 2021
Merged

T15801 remove tag 2 #15833

merged 13 commits into from
Dec 20, 2021

Conversation

niden
Copy link
Sponsor Member

@niden niden commented Dec 17, 2021

Hello!

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR
  • I have updated the relevant CHANGELOG
  • I have created a PR for the documentation about this change

Second iteration of removing Tag from the framework. Because of backwards compatibility, the class must stay as is for now because of Volt and the Tag\Select. The changes for the users will be massive so we need to take this very slowly.

Thanks

@niden niden requested a review from Jeckerson December 17, 2021 21:40
@niden niden self-assigned this Dec 17, 2021
@niden niden added 5.0 The issues we want to solve in the 5.0 release new feature request Planned Feature or New Feature Request labels Dec 17, 2021
@niden niden merged commit 7dab20e into phalcon:5.0.x Dec 20, 2021
@niden niden deleted the T15801-remove-tag-2 branch December 20, 2021 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5.0 The issues we want to solve in the 5.0 release new feature request Planned Feature or New Feature Request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants