Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

T15866 title separator #15867

Merged
merged 4 commits into from
Jan 19, 2022
Merged

T15866 title separator #15867

merged 4 commits into from
Jan 19, 2022

Conversation

niden
Copy link
Sponsor Member

@niden niden commented Jan 19, 2022

Hello!

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR
  • I have updated the relevant CHANGELOG
  • I have created a PR for the documentation about this change

Removed $separator from Phalcon\Html\Helper\Title::__invoke()
Added Phalcon\Html\Helper\Title::setSeparator()

Thanks

@niden niden added this to Working on it in Phalcon Roadmap Jan 19, 2022
@niden niden self-assigned this Jan 19, 2022
@niden niden requested a review from Jeckerson January 19, 2022 16:43
@niden niden added 5.0 The issues we want to solve in the 5.0 release bug A bug report status: medium Medium labels Jan 19, 2022
@niden niden merged commit 1706073 into phalcon:5.0.x Jan 19, 2022
Phalcon Roadmap automation moved this from Working on it to Implemented Jan 19, 2022
@niden niden deleted the T15866-title-separator branch January 19, 2022 16:58
@niden niden linked an issue Jan 19, 2022 that may be closed by this pull request
[BUG]: Phalcon\Html\Helper\Title invoke - remove separator #15866
Closed
@niden niden removed this from Implemented in Phalcon Roadmap Jan 19, 2022
@niden niden mentioned this pull request Jan 19, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jeckerson Jeckerson Jeckerson approved these changes

Assignees

@niden niden

Labels
5.0 The issues we want to solve in the 5.0 release bug A bug report status: medium Medium
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG]: Phalcon\Html\Helper\Title invoke - remove separator
2 participants
@niden @Jeckerson