Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

T15880 route getname #15881

Merged
merged 3 commits into from
Jan 27, 2022
Merged

T15880 route getname #15881

merged 3 commits into from
Jan 27, 2022

Conversation

niden
Copy link
Sponsor Member

@niden niden commented Jan 27, 2022

Hello!

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR
  • I have updated the relevant CHANGELOG
  • I have created a PR for the documentation about this change

Fixed Phalcon\Mvc\Router\Route::getName() and Phalcon\Mvc\Router\Route::getHostname() to also return null
Fixed Phalcon\Mvc\Router\RouteInterface::getName() and Phalcon\Mvc\Router\RouteInterface::getHostname() to also return null

Thanks

@niden niden added breaks bc Functionality that breaks Backwards Compatibility bug A bug report status: medium Medium 5.0 The issues we want to solve in the 5.0 release labels Jan 27, 2022
@niden niden requested a review from Jeckerson January 27, 2022 16:51
@niden niden self-assigned this Jan 27, 2022
@niden niden linked an issue Jan 27, 2022 that may be closed by this pull request
@niden niden merged commit 1f7f982 into phalcon:5.0.x Jan 27, 2022
@niden niden deleted the T15880-route-getname branch January 27, 2022 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5.0 The issues we want to solve in the 5.0 release breaks bc Functionality that breaks Backwards Compatibility bug A bug report status: medium Medium
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Route::getName() return type
2 participants