Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding InitializationAwareInterface #15916

Merged
merged 1 commit into from
Mar 16, 2022
Merged

Adding InitializationAwareInterface #15916

merged 1 commit into from
Mar 16, 2022

Conversation

Fenikkusu
Copy link
Contributor

@Fenikkusu Fenikkusu commented Feb 27, 2022 •
edited
Loading

Hello!

  • Type: new feature
  • Link to issue: N/A

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR
  • I have updated the relevant CHANGELOG
  • I have created a PR for the documentation about this change

Small description of change:

I find myself constantly adding a method of 'initialize' to most everything, and calling it either in the service creation or through some other means. This PR adds an interface to allow the DIC to call it automatically given the class implements the interface in the same way the InjectionAwareInterface works.

Thanks

@Fenikkusu Fenikkusu force-pushed the 5.0.x-initialization branch 2 times, most recently from fa0d840 to 72c3394 Compare February 27, 2022 06:33
@Fenikkusu Fenikkusu changed the title [WIP] Adding InitializationAwareInterface Adding InitializationAwareInterface Feb 27, 2022
@niden niden merged commit 552e903 into phalcon:5.0.x Mar 16, 2022
@niden niden added new feature request Planned Feature or New Feature Request 5.0 The issues we want to solve in the 5.0 release labels Mar 16, 2022
@niden
Copy link
Sponsor Member

niden commented Mar 16, 2022

Thank you @Fenikkusu !

@niden niden added this to Working on it in Phalcon Roadmap Mar 16, 2022
@niden niden moved this from Working on it to Implemented in Phalcon Roadmap Mar 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@niden niden niden approved these changes

Assignees
No one assigned
Labels
5.0 The issues we want to solve in the 5.0 release new feature request Planned Feature or New Feature Request
Projects
Phalcon v5
Archived in project
Phalcon Roadmap
  
Implemented
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Fenikkusu @niden