Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

T15978 html string 3 #15983

Merged
merged 16 commits into from
Jun 8, 2022
Merged

T15978 html string 3 #15983

merged 16 commits into from
Jun 8, 2022

Conversation

niden
Copy link
Sponsor Member

@niden niden commented Jun 8, 2022

Hello!

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR
  • I have updated the relevant CHANGELOG
  • I have created a PR for the documentation about this change

Corrected the StringVal filter to now use htmlspecialchars(). Added StringValLegacy filter with the same functionality as before for PHP < 8.1

Thanks

@niden niden self-assigned this Jun 8, 2022
@niden niden requested a review from Jeckerson June 8, 2022 20:43
@niden niden added bug A bug report status: medium Medium 5.0 The issues we want to solve in the 5.0 release labels Jun 8, 2022
@niden niden merged commit ad07275 into phalcon:5.0.x Jun 8, 2022
@niden niden deleted the T15978-html-string-3 branch June 8, 2022 21:44
@niden niden mentioned this pull request Jun 8, 2022
Closed
@niden niden linked an issue Jun 8, 2022 that may be closed by this pull request
[BUG]: Filter::StringVal with <<>> #15978
Closed
@niden niden mentioned this pull request Jun 8, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jeckerson Jeckerson Jeckerson approved these changes

Assignees

@niden niden

Labels
5.0 The issues we want to solve in the 5.0 release bug A bug report status: medium Medium
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG]: Filter::StringVal with <<>>
2 participants
@niden @Jeckerson