Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#16337 - Adjust Validation:validate() signature #16338

Merged
merged 3 commits into from Jan 11, 2024
Merged

#16337 - Adjust Validation:validate() signature #16338

merged 3 commits into from Jan 11, 2024

Conversation

Jeckerson
Copy link
Member

@Jeckerson Jeckerson commented May 14, 2023 •
edited by niden

Hello!

  • Type: bug fix code quality

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR
  • I have updated the relevant CHANGELOG
  • I have created a PR for the documentation about this change

Small description of change:

Thanks

@Jeckerson Jeckerson self-assigned this May 14, 2023
@niden niden force-pushed the #16337-validate-signature branch from c721c22 to f4f7a0b Compare July 18, 2023 23:59
@niden
Copy link
Sponsor Member

niden commented Jul 19, 2023

@Jeckerson we need the stubs to generate Messages | false. I think the false is what throws it off.

@niden niden merged commit 101fbf2 into 5.0.x Jan 11, 2024
72 checks passed
@niden niden deleted the #16337-validate-signature branch January 11, 2024 20:45
@niden niden mentioned this pull request Jan 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@niden niden niden approved these changes

Assignees

@Jeckerson Jeckerson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Jeckerson @niden