T16308 di dynamic properties 4

[niden]

Hello!

• Type: bug fix
• Link to issue: [BUG]: Creation of dynamic property TestTask::$db is deprecated #16308

In raising this pull request, I confirm the following:

• I have read and understood the Contributing Guidelines
• I have checked that another pull request for this purpose does not exist
• I wrote some tests for this PR
• I have updated the relevant CHANGELOG
• I have created a PR for the documentation about this change

Extended Phalcon\Di\Injectable from stdClass to remove the deprecation warning (dynamic properties) for PHP 8.2

Credit: @escribiendocodigo

Thanks

[hakimio]

@niden does this also fix following deprecation errors?

Use of "static" in callables is deprecated
Use of "self" in callables is deprecated

[niden]

@niden does this also fix following deprecation errors?

Use of "static" in callables is deprecated
Use of "self" in callables is deprecated

Not yet. I am looking at it and it could be that it comes from Zephir than Phalcon. I will have to talk to @Jeckerson when he comes back

[fichtner]

I tried the patch but to no avail for the following... I'm seeing:

PHP Deprecated:  Creation of dynamic property OPNsense\Core\Api\MenuController::$request is deprecated in /usr/local/opnsense/mvc/app/controllers/OPNsense/Base/ApiControllerBase.php on line 195
PHP Deprecated:  Creation of dynamic property OPNsense\Core\Api\MenuController::$session is deprecated in /usr/local/opnsense/mvc/app/controllers/OPNsense/Base/ControllerRoot.php on line 149
PHP Deprecated:  Creation of dynamic property OPNsense\Core\Api\MenuController::$security is deprecated in /usr/local/opnsense/mvc/app/controllers/OPNsense/Base/ApiControllerBase.php on line 298

It looks to be from the Phalcon\Mvc\Controller class. Any open ticket that tracks these?

Cheers,
Franco

[hakimio]

@fichtner #16263

[fichtner]

@hakimio thanks, subscribed. though there is no collection of individual dynamic variables causing this. if the problem is wide spread it might make sense to record which ones have been reported and which ones have been addressed (by this patch). the situation is not overly transparent unfortunately.

[paulobing]

Hi @niden ! Do you have any updates on this?
I'm experiencing the same using PHP 8.2.11 + Phalcon 5.3.11

[fichtner]

Nothing changed to my knowledge. We had to disable deprecation warnings because of this so it’s not a quick check. 😉

[hakimio]

You can follow this issue to get progress updates: zephir-lang/zephir#2405