Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

T16414 route routeid type error #16415

Merged
merged 3 commits into from
Aug 24, 2023
Merged

T16414 route routeid type error #16415

merged 3 commits into from
Aug 24, 2023

Conversation

niden
Copy link
Sponsor Member

@niden niden commented Aug 24, 2023

Hello!

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR
  • I have updated the relevant CHANGELOG
  • I have created a PR for the documentation about this change

Forced routeId in Phalcon\Mvc\Router\Route to always return a string

Thanks

@niden niden requested a review from Jeckerson August 24, 2023 13:18
@niden niden self-assigned this Aug 24, 2023
@niden niden linked an issue Aug 24, 2023 that may be closed by this pull request
[BUG[: Error on Route::getRouteId() when mounting collections #16414
Closed
@niden niden added bug A bug report 5.0 The issues we want to solve in the 5.0 release status: medium Medium labels Aug 24, 2023
@niden niden merged commit fd62e2a into phalcon:5.0.x Aug 24, 2023
37 of 38 checks passed
@niden niden deleted the T16414-route-routeid-type-error branch August 24, 2023 13:46
@niden niden mentioned this pull request Aug 24, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jeckerson Jeckerson Jeckerson approved these changes

Assignees

@niden niden

Labels
5.0 The issues we want to solve in the 5.0 release bug A bug report status: medium Medium
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG[: Error on Route::getRouteId() when mounting collections
2 participants
@niden @Jeckerson