Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added return type for Manager::getReusableRecords #16493

Merged
merged 9 commits into from
Jan 5, 2024

Conversation

kuhler-Stratege
Copy link

Hello!

  • Type: documentation

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist

Small description of change:
In my IDE-stubs I have seen that the function getReusableRecord of the class Phalcon\Mvc\Model\Manager is marked as void method. I now added a comment with a return type of mixed.

Thanks

@Jeckerson
Copy link
Member

@kuhler-Stratege Please rebase or merge 5.0.x branch.

@niden niden merged commit 750f56c into phalcon:5.0.x Jan 5, 2024
33 of 34 checks passed
@niden
Copy link
Sponsor Member

niden commented Jan 5, 2024

Thank you @kuhler-Stratege

@niden niden added documentation Documentation required 5.0 The issues we want to solve in the 5.0 release labels Jan 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5.0 The issues we want to solve in the 5.0 release documentation Documentation required
Projects
Status: Released
Development

Successfully merging this pull request may close these issues.

None yet

4 participants