Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added return type for Manager::getReusableRecords #16493

Merged
merged 9 commits into from
Jan 5, 2024
2 changes: 1 addition & 1 deletion .github/ISSUE_TEMPLATE/bug_report.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ Questions? Forum: https://phalcon.io/forum or Discord: https://phalcon.io/discor
A clear and concise description of what the bug is.

**To Reproduce**
> Provide output if related. Provide coredump if any. Use https://docs.phalcon.io/en/latest/generating-backtrace as reference.
> Provide output if related. Provide coredump if any. Use https://docs.phalcon.io/latest/generating-backtrace as reference.

Steps to reproduce the behavior:

Expand Down
6 changes: 3 additions & 3 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -34,9 +34,9 @@ Please report bugs when you've exhausted all of the above options.
## Bug Report Checklist

* Make sure you are using the latest released version of Phalcon before submitting a bug report. Bugs in versions older than the latest released one will not be addressed by the core team (so long as the version is not LTS).
* If you have found a bug it is important to add relevant reproducibility information to your issue to allow us to reproduce the bug and fix it quicker. Add a script, small program or repository providing the necessary code to make everyone reproduce the issue reported easily. If a bug cannot be reproduced by the development it would be difficult provide corrections and solutions. [Submit Reproducible Test](https://docs.phalcon.io/en/latest/reproducible-tests) for more information
* If you have found a bug it is important to add relevant reproducibility information to your issue to allow us to reproduce the bug and fix it quicker. Add a script, small program or repository providing the necessary code to make everyone reproduce the issue reported easily. If a bug cannot be reproduced by the development it would be difficult provide corrections and solutions. [Submit Reproducible Test](https://docs.phalcon.io/latest/reproducible-tests/) for more information
* Be sure that information such as OS, Phalcon version and PHP version are part of the bug report
* If you're submitting a [Segmentation Fault](https://en.wikipedia.org/wiki/Segmentation_fault) error, we would require a backtrace, please see [Generating a Backtrace](https://docs.phalcon.io/en/latest/generating-backtrace)
* If you're submitting a [Segmentation Fault](https://en.wikipedia.org/wiki/Segmentation_fault) error, we would require a backtrace, please see [Generating a Backtrace](https://docs.phalcon.io/latest/generating-backtrace)

## Pull Request Checklist

Expand All @@ -48,7 +48,7 @@ Please report bugs when you've exhausted all of the above options.

## Requesting Features

If you have a change or new feature in mind, please fill a [NFR](https://docs.phalcon.io/en/latest/new-feature-request) on the GitHub. Alternatively you may also request features via [the FeatHub page](https://feathub.com/phalcon/cphalcon).
If you have a change or new feature in mind, please fill a [NFR](https://docs.phalcon.io/latest/new-feature-request) on the GitHub. Alternatively you may also request features via [the FeatHub page](https://feathub.com/phalcon/cphalcon).


Thanks!
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ You can either download a binary package for the system of your choice or build

## Installation

For detailed installation instructions you can check our [installation](https://docs.phalcon.io/5.0/installation) page in the docs.
For detailed installation instructions you can check our [installation](https://docs.phalcon.io/latest/installation/) page in the docs.

## Generating API Documentation

Expand Down
10 changes: 5 additions & 5 deletions ext/phalcon/di/di.zep.c

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions phalcon/Di/Di.zep
Original file line number Diff line number Diff line change
Expand Up @@ -388,7 +388,7 @@ class Di implements DiInterface
* ];
* ```
*
* @link https://docs.phalcon.io/en/latest/reference/di.html
* @link https://docs.phalcon.io/latest/di/
*/
public function loadFromPhp(string! filePath) -> void
{
Expand Down Expand Up @@ -430,7 +430,7 @@ class Di implements DiInterface
* className: \Acme\User
* ```
*
* @link https://docs.phalcon.io/en/latest/reference/di.html
* @link https://docs.phalcon.io/latest/di/
*/
public function loadFromYaml(string! filePath, array! callbacks = null) -> void
{
Expand Down
2 changes: 2 additions & 0 deletions phalcon/Mvc/Model/Manager.zep
Original file line number Diff line number Diff line change
Expand Up @@ -1670,6 +1670,8 @@ class Manager implements ManagerInterface, InjectionAwareInterface, EventsAwareI
*
* @param string $modelName
* @param string $key
*
* @return mixed
*/
public function getReusableRecords(string! modelName, string! key)
{
Expand Down
Loading