Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

T16560 min max validator #16561

Merged
merged 5 commits into from Apr 4, 2024
Merged

T16560 min max validator #16561

merged 5 commits into from Apr 4, 2024

Conversation

niden
Copy link
Sponsor Member

@niden niden commented Apr 4, 2024

Hello!

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR
  • I have updated the relevant CHANGELOG
  • I have created a PR for the documentation about this change

Fixed Phalcon\Filter\Validation\Validator\StringLength::validate() to correctly use the include parameter

Thanks

@niden niden added bug A bug report status: medium Medium 5.0 The issues we want to solve in the 5.0 release labels Apr 4, 2024
@niden niden requested a review from Jeckerson April 4, 2024 13:27
@niden niden self-assigned this Apr 4, 2024
@niden niden merged commit 655b299 into phalcon:5.0.x Apr 4, 2024
49 of 50 checks passed
@niden niden deleted the T16560-min-max-validator branch April 4, 2024 14:45
@niden niden mentioned this pull request Apr 4, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jeckerson Jeckerson Jeckerson approved these changes

Assignees

@niden niden

Labels
5.0 The issues we want to solve in the 5.0 release bug A bug report status: medium Medium
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@niden @Jeckerson