Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INVO Bug] One Bug happens when edit an item #37

Closed
hknguyenvu opened this issue Nov 21, 2014 · 3 comments
Closed

[INVO Bug] One Bug happens when edit an item #37

hknguyenvu opened this issue Nov 21, 2014 · 3 comments
Assignees

Comments

@hknguyenvu
Copy link

When I find out, I saw one bug in INVO project.

This bug happens on all model. It displays wrong notice when edit an item

Scenario:

  • Choose any model, search them. In this scenario, i chose Company
  • Click _Edit_ any item.
  • Clear data of any required row.
  • Click _Save_
  • The notice appear (Something like this: "Name is required")
  • Add info for that required row
  • Click _Save_
  • The notice appear not correctly

Expect notice: Company was updated successfully

Actual notice: Company was created successfully

I think this bug happens because of code:

CompaniesController.php

    $data = $this->request->getPost();
    if (!$form->isValid($data, $company)) {
            foreach ($form->getMessages() as $message) {
                $this->flash->error($message);
            }
            return $this->forward('companies/new');
        }

I'm just a newbie with Phalcon. So how can we fix that?

Thanks so much.

@sergeysviridenko
Copy link
Contributor

I couldn't reproduce this issue. It works fine for me. I propose to close this issue.

@hknguyenvu
Copy link
Author

Yeah, this problem was posted very long time ago. Maybe it's not happened anymore. Let's forget it.

@sergeysviridenko
Copy link
Contributor

@EnvySky If problem will appear again, feel free to open new issue. Thank you for report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants